Skip to content

Strings never freed when retrieving text from virtual buffers #591

@nvaccessAuto

Description

@nvaccessAuto

Reported by jteh on 2010-03-08 16:37
Str:

  1. Open http://www.nvda-project.org/ in Firefox and move focus inside the buffer.
  2. Press NVDA+ctrl+z to activate the Python console.
  3. Type:
    ti = focus.virtualBuffer.makeTextInfo("all") for i in xrange(20000): t = ti.text
    Actual: Massive memory leak (NVDA shoots up to about 300 mb here).
    Expected: Uh... no memory leak.
    Note that closing the browser doesn't clean this up.

This happens because VBuf_getTextInRange allocates a string on the server side which is then marshalled to the client but never freed. We figured that ctypes was freeing the string when it was garbage collected by Python (which is actually incorrect, since ctypes didn't allocate it), but it seems that ctypes (correctly) doesn't do this after all.

Metadata

Metadata

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions