Comment 12 by jteh on 2010-09-28 02:36
Okay. Code review. :)

First, I'm curious as to why you decided to reload all app modules, rather than just the current app module. Having said that, this certainly isn't a problem; I'm just curious. One advantage of doing it the way you ahve is that you can reload app modules from the Tools menu, which you wouldn't be able to do if it was only the current module.

Please change all user visible occurrences of appModules to "app modules" (space between, no capital m).

=== modified file 'source/appModuleHandler.py'

Each appModule will be reloaded imediately as a reaction on a first event coming from the process."""

Knit: Docstring close quotes should generally be on their own line. Also, immediately is spelt with a double m.

=== modified file 'source/appModules/_default.py'
def script_reloadAppModules(self,keyPress):
ui.message(_("Reloading appModules..."))

I'd remove the "..." here. It makes it seem as if the user should expect "done" or similar, which you can't do as per your comment later.

script_reloadAppModules.doc=_("Reloads appModules from the disk without restarting NVDA, which can be Useful for developers")

I'd remove "from the disk". If you really want to keep it, change it to "from disk".

You need to add a keyboard binding to the laptop layout as well. The same one will do.

=== modified file 'user_docs/en/changes.t2t'

+- Ability to reload appModules without restarting of whole NVDA was introduced for convenience of appModule developers. Use tools->Reload appModules in the NVDA menu or NVDA+ctrl+f3. (#544)

I'd change the first sentence to "For the convenience of app module developers, app modules can now be reloaded without restarting NVDA."

You also need to add a very short section on this to the Extra Tools section of the User Guide.

Overall, great work - thanks.
Changes:
Milestone changed from None to 2010.3

Uh oh!

A possibility to reload appModules without NVDA restart #544

Description

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions