Skip to content

Date and time information is not spoken correctly in some languages because of small buffer size in winKernel.GetDateFormat and GetTimeFormat #471

@nvaccessAuto

Description

@nvaccessAuto

Reported by ragb on 2009-11-10 15:09
In winkernel.GetDateFormat (line 76 of current trunk winkernel.py) the created unicode buffer that will have the date string is sized to 32 characteres. At least in Portuguese (and some other languages I think) there are situations when Windows returns a 33, 34 or more characters string. The GetTimeFormat may also suffer from the same bug.

There are to solutions to this problem. The Obvious one is to increase to buffer size to 64 or 128 chars, it must work for every language out there.
The other solution is partialy described here:
[http://msdn.microsoft.com/en-us/library/dd318086%28VS.85%29.aspx]
and requires to calls to the kernel32.GetDateFormat. One with the output buffer set to NULL and size to 0 to get the string size on the return value, and other to get the string itself for a allocated buffer with the previously got size value.

I've no way to compile NVDA from source right now so if someone could do something before 2009.1 it would be fine... If not I will try to write a patch but don't know when...

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions