-
-
Notifications
You must be signed in to change notification settings - Fork 784
Signal routing button presses for Freedom Scientific displays #20077
Copy link
Copy link
Labels
component/braille-display-driversfeatureneeds-technical-investigationA technical investigation is required to progress the issue.A technical investigation is required to progress the issue.p5https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityhttps://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#prioritytriagedHas been triaged, issue is waiting for implementation.Has been triaged, issue is waiting for implementation.
Metadata
Metadata
Assignees
Labels
component/braille-display-driversfeatureneeds-technical-investigationA technical investigation is required to progress the issue.A technical investigation is required to progress the issue.p5https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityhttps://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#prioritytriagedHas been triaged, issue is waiting for implementation.Has been triaged, issue is waiting for implementation.
Type
Fields
Give feedbackNo fields configured for Feature.
Is your feature request related to a problem? Please describe.
Braille routing events for Freedom Scientific displays are currently emitted on button release, for each button.
Describe the solution you'd like
Displays send packets when these buttons are pressed, communicating that to NVDA would be desirable for upcoming improvements to text selection.
Here are debug traces showing that this works (on a Focus 5th generation with 40 cells):
Packet type 0x4 is for routing button events, first argument is the 0-based cell index, second is the type of event (1 for press, 0 for release).
The driver could either emit new routing events on button presses or keep tracck of all currently pressed buttons and emit a single routing event with a list of all simultaneously pressed buttons when the last one is released.
Describe alternatives you've considered
Keep the driver as is.
Additional context
These events are currently explicitly ignored (
nvda/source/brailleDisplayDrivers/freedomScientific.py
Line 487 in 364c109