Skip to content

Changes made in Vision settings dialog can be saved to disk even when the dialog is dismissed #19765

@CyrilleB79

Description

@CyrilleB79

Issue found while investigating a solution for #11405. Vision providers are somewhat hard to understand, more when there are such bugs...

Steps to reproduce

  1. Open NVDA settings, vision category
  2. Check one of the highlighters, e.g. "Highlight system focus"
  3. Press NVDA+shift+c to save config
  4. Press escape to dismiss the changes done in the settings panel
  5. Press NVDA+control+R to reload the config from disk

Actual behavior

  1. As expected, the focus higlighter immediately appears, since these checkboxes should have immediate effect
  2. As expected, the changes done in in Vision settings are rolled back, i.e. the focus highlighter disappears.
  3. The focus highlighter appears again, meaning it had been saved to disk at step 3.

Expected behavior

At step 3, none of the changes done in the settings dialog should be written to disk, since writing in config.conf should only be done when one presses OK in the settings dialog to validate it.

NVDA logs, crash dumps and other attachments

Not provided

System configuration

NVDA installed/portable/running from source

Installed

NVDA version

2026.1rc5

Windows version

Windows 11 25H2 (AMD64) build 26200.7840

Name and version of other software in use when reproducing the issue

N/A

Other information about your system

N/A

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors

2025.2 also writes to disk at step 3.

If NVDA add-ons are disabled, is your problem still occurring?

Yes

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

Not tested.

Metadata

Metadata

Assignees

No one assigned

    Labels

    component/NVDA-GUIcomponent/visionFramework for assisting users with low visionfeature/configurationMaking NVDA more configurable.p3https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#prioritytriagedHas been triaged, issue is waiting for implementation.

    Type

    No fields configured for Bug.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions