Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request introduces a new debouncing utility to the NVDA codebase and applies it to the browse mode elements list filter functionality. The debouncer provides a reusable mechanism for rate-limiting function calls by executing the first call immediately and debouncing subsequent calls within a cooldown period.
Changes:
- Added a new
debounceLimiterdecorator insource/utils/debounce.pythat supports GUI and daemon thread targets - Replaced manual
wx.CallLatertimer management in browse mode's elements list filter with the new debouncer - Updated type hints in
browseMode.pyfromOptional[X]/Union[X, Y]to modern PEP 604 syntax (X | None,X | Y)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| source/utils/debounce.py | New utility module providing the debounceLimiter decorator for debouncing function calls with configurable cooldown and delay times, supporting both GUI and daemon thread execution |
| tests/unit/test_util/test_debounce.py | Comprehensive unit tests for the debouncer covering immediate execution, coalescing, cooldown behavior, and per-instance state tracking |
| source/browseMode.py | Refactored elements list filter to use the new debouncer, removed manual timer management, and modernized type hints throughout the file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5 tasks
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
seanbudd
commented
Feb 26, 2026
seanbudd
commented
Feb 26, 2026
SaschaCowley
requested changes
Mar 3, 2026
Co-authored-by: Sascha Cowley <16543535+SaschaCowley@users.noreply.github.com>
SaschaCowley
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Inspired by #19686
Summary of the issue:
We regularly run into problems where the GUI being updated frequently causing issues.
We fix this using a ratelimiter/debouncer.
We do not have a generic debouncer in NVDA.
Description of user facing changes:
none
Description of developer facing changes:
Adds a generic debouncer to NVDA
Description of development approach:
This pull request introduces a new debouncing utility for limiting the frequency of function calls, primarily to improve GUI responsiveness and reduce unnecessary processing in NVDA. The main changes include the addition of the
debounceLimiterdecorator, its integration into thebrowseMode.pyfile for filtering elements, and comprehensive unit tests to verify its behavior. The pull request also modernizes type annotations throughoutbrowseMode.pyfor improved readability and consistency.Debounce utility and integration:
debounceLimiterdecorator inutils/debounce.pyto control the execution rate of functions, supporting both GUI and daemon threads.debounceLimiterinto the filtering logic of the elements list dialog inbrowseMode.py, replacing manual timer handling for improved efficiency and code clarity. [1] [2]Testing
Introduced
tests/unit/test_util/test_debounce.pywith unit tests covering various debounce scenarios, including cooldown, delay, call coalescing, and per-instance limiting.Manually tested filtering the elements list dialog
Known issues with pull request:
None
Code Review Checklist: