Report grammar errors according to configuration#19257
Merged
Merged
Conversation
Collaborator
Author
|
I'm using a sound downloaded From Pixabay. Here's the summary of the license contents. |
CyrilleB79
reviewed
Nov 23, 2025
CyrilleB79
reviewed
Nov 23, 2025
CyrilleB79
reviewed
Nov 23, 2025
CyrilleB79
reviewed
Nov 23, 2025
CyrilleB79
reviewed
Nov 23, 2025
CyrilleB79
reviewed
Nov 23, 2025
CyrilleB79
left a comment
Contributor
There was a problem hiding this comment.
Thanks for taking this.
Co-authored-by: Cyrille Bougot <cyrille.bougot2@laposte.net>
Co-authored-by: Cyrille Bougot <cyrille.bougot2@laposte.net>
Co-authored-by: Cyrille Bougot <cyrille.bougot2@laposte.net>
Co-authored-by: Cyrille Bougot <cyrille.bougot2@laposte.net>
seanbudd
approved these changes
Dec 5, 2025
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
Collaborator
Author
|
@seanbudd @Qchristensen , let's accept Sean's suggestion. The sound was described with two words since I tried to add two different sounds, but finally we decided to add just one sound in this PR. |
Collaborator
Author
|
For me this is ready. |
Qchristensen
approved these changes
Dec 5, 2025
Qchristensen
left a comment
Member
There was a problem hiding this comment.
Reads well, and I agree with Sean's suggested change to remove "or glitch" from the the "short buzzer or glitch" line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #19218
Summary of the issue:
Grammar errors are spoken when NVDA is configured to report them with sounds or in braille.
Description of user facing changes:
Description of developer facing changes:
None.
Description of development approach:
speech.speak.py, seen how the "invalid-spelling" attribute is addressed, to handle the "invalid-grammar" attribute appropriately.braille.py, "invalid-grammar" has been added tofontAttributeFormattingMarkers.Testing strategy:
Tested the different ways of reporting spelling and gramar errors.
Known issues with pull request:
None.
Code Review Checklist: