Comment 2 by jteh on 2011-11-30 23:08
Thanks for the driver. Code review:

  def __init__(self):

...

          if hwID.find(HEDO_MOBIL_USBID) == -1:

nit: This can be written more Pythonically as HEDO_MOBIL_USBID not in hwID.

  def display(self, cells):

...

      # cells will be padded up to 1 + numStatusCells + numCells.
      expectedLength = 1 + HEDO_MOBIL_STATUS_CELL_COUNT + HEDO_MOBIL_CELL_COUNT
      line += chr(0) * (expectedLength - len(line))

The cells will already be padded up to numCells, so you just need to pad for status cells, rather than calculating the total length. This padding probably isn't documented. If it isn't, I'll update the code doc. :)

The gesture map and gesture classes at the bottom are indented with spaces. Please convert these to tabs to match other NVDA code.

It'd be great if you could provide a User Guide section for this display. See user_docs/en/userGuide.t2t. Just use the section I wrote for the other hedo display as a base. Feel free to just attach the new section, rather than the whole User Guide.

Thanks again for your contributions.
Changes:
Milestone changed from None to 2012.1

Uh oh!

Braille Display Driver Hedo Germany #1897

Description

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions