Fix Remote Access as follower#18947
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes Remote Access functionality as a follower by migrating keyboard input code from deprecated winUser constants to new enum members in winBindings.user32. The changes consolidate duplicate constant definitions and update all affected code to use the new standardized structures.
Key changes:
- Removed duplicate INPUT-related structures and constants from
_remoteClient.input - Updated all keyboard input code to use
winBindings.user32enums instead ofwinUserconstants - Added deprecation warnings for moved constants in
winUser
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| user_docs/en/changes.md | Documents deprecation of INPUT and KEYEVENTF constants from winUser |
| source/winUser.py | Adds deprecation symbols and removes duplicate constants |
| source/winBindings/user32.py | Defines new KEYEVENTF and INPUT_TYPE enums with proper documentation |
| source/keyboardHandler.py | Updates to use new KEYEVENTF.KEYUP enum |
| source/easeOfAccess.py | Migrates to winBindings.user32 INPUT_TYPE and KEYEVENTF enums |
| source/brailleInput.py | Updates keyboard input to use new enum constants |
| source/_remoteClient/input.py | Removes duplicate structures and uses winBindings.user32 types |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
seanbudd
approved these changes
Sep 19, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #18938
Summary of the issue:
Attempting to control NVDA via the Remote Access feature fails on recent alphas.
Description of user facing changes:
It works again.
Description of developer facing changes:
Some constants from
winUserhave been made enum members inwinBindings.user32.Description of development approach:
INPUT,KEYBDINPUT,HARDWAREINPUT,MOUSEINPUT,INPUT_TYPEandKEYEVENTFfrom_remoteClient.input.winBindings.user32.winUserand added deprecation code and notes to the user docs.Testing strategy:
Ran NVDA from source, and connected as follower. Controlled with another computer (running 2025.2rc1).
Known issues with pull request:
None known.
Code Review Checklist: