Update espeak-ng to resolve espeak-ng/espeak-ng#1031#18633
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the eSpeak NG dependency to resolve a pronunciation issue where "has been" was incorrectly stressed as an adjective instead of a verb form in English.
- Updated eSpeak NG submodule from commit
a4ca101to3b8ef3d - Updated documentation to reflect the new commit hash and issue reference
- Incorporates upstream fix for English pronunciation stress patterns
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| user_docs/en/changes.md | Updated changelog entry with new eSpeak NG commit hash and added issue reference |
| projectDocs/dev/createDevEnvironment.md | Updated development documentation with new eSpeak NG commit requirement |
| include/espeak | Updated git submodule pointer to new eSpeak NG commit |
seanbudd
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
espeak-ng/espeak-ng#1031.
Summary of the issue:
Espeak puts adjectival stress on "has been" in English in all cases, even when it's used as a verb. This was resolved upstream, and NVDA should take in this fix.
Description of how this pull request fixes the issue:
Updates espeak-ng to commit 3b8ef3d.
Testing strategy:
Verified that "has been" is pronounced correctly as a verb form (en-gb, max variant).
Known issues with pull request:
None known.
Code Review Checklist: