Add option to mute Remote Access when not controlling the remote computer#18630
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new configuration option to automatically mute Remote Access audio when controlling the local computer, addressing user feedback about disruptive sounds from remote sessions. The feature provides automatic muting behavior while preserving manual control options.
Key changes:
- Added configuration setting to enable automatic muting when controlling local computer
- Refactored mute logic to support both automatic and manual muting scenarios
- Integrated the feature into the Remote Access settings UI with appropriate documentation
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| source/_remoteClient/client.py | Refactored mute toggle logic and added automatic muting when connecting as leader or switching to local control |
| source/config/configSpec.py | Added new boolean configuration option muteOnLocalControl with default value of False |
| source/gui/settingsDialogs.py | Added checkbox control for the new mute option in Remote Access settings panel |
| user_docs/en/userGuide.md | Added documentation section explaining the new mute option and its behavior |
| user_docs/en/changes.md | Added changelog entry for the new Remote Access muting feature |
seanbudd
approved these changes
Aug 12, 2025
Qchristensen
requested changes
Aug 13, 2025
Qchristensen
left a comment
Member
There was a problem hiding this comment.
Looks good, just made one suggestion to note HOW to manually mute / unmute (by assigning a gesture to it).
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
4171afa to
b1a665c
Compare
Qchristensen
approved these changes
Aug 14, 2025
Qchristensen
left a comment
Member
There was a problem hiding this comment.
Changes look great, thanks Sascha!
seanbudd
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #18104
Summary of the issue:
It is often disruptive to hear what is happening on the remote computer when controling the local computer. As such, users want the ability to automatically mute output from the remote computer when controling the local computer.
Description of user facing changes:
Added an option to mute the remote computer when controlling the local computer. If enabled:
This option is disabled by default.
Description of developer facing changes:
None
Description of development approach:
_remoteClient.client.RemoteClient.toggleMuteto rely on an internal use only method that only toggles the mute state, without performing error checks or producing user output.Testing strategy:
Connected and disconnected as leader with this setting enabled and disabled and ensured it behaved as expected.
Known issues with pull request:
None
Code Review Checklist:
@coderabbitai summary