Skip to content

Add option to mute Remote Access when not controlling the remote computer#18630

Merged
SaschaCowley merged 7 commits into
betafrom
muteWhenNotSendingKeys
Aug 14, 2025
Merged

Add option to mute Remote Access when not controlling the remote computer#18630
SaschaCowley merged 7 commits into
betafrom
muteWhenNotSendingKeys

Conversation

@SaschaCowley

@SaschaCowley SaschaCowley commented Aug 6, 2025

Copy link
Copy Markdown
Member

Link to issue number:

Closes #18104

Summary of the issue:

It is often disruptive to hear what is happening on the remote computer when controling the local computer. As such, users want the ability to automatically mute output from the remote computer when controling the local computer.

Description of user facing changes:

Added an option to mute the remote computer when controlling the local computer. If enabled:

  • Mutes the remote computer when first connecting as leader;
  • Automatically mutes the remote computer when switching from remote to local control.
    This option is disabled by default.

Description of developer facing changes:

None

Description of development approach:

  • Refactored _remoteClient.client.RemoteClient.toggleMute to rely on an internal use only method that only toggles the mute state, without performing error checks or producing user output.
  • When connecting as leader, toggle to muted using the internal method if we should mute when controling the local machine.
  • Use the public method to toggle mute when switching from remote to local control (done so there is clear output, just as is done when switching the other way).
  • Added a config item to the config spec that mediates this behaviour.. Also added to the Remote Access settings panel.

Testing strategy:

Connected and disconnected as leader with this setting enabled and disabled and ensured it behaved as expected.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Aug 12, 2025
@SaschaCowley SaschaCowley marked this pull request as ready for review August 12, 2025 02:22
Copilot AI review requested due to automatic review settings August 12, 2025 02:22
@SaschaCowley SaschaCowley requested review from a team as code owners August 12, 2025 02:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new configuration option to automatically mute Remote Access audio when controlling the local computer, addressing user feedback about disruptive sounds from remote sessions. The feature provides automatic muting behavior while preserving manual control options.

Key changes:

  • Added configuration setting to enable automatic muting when controlling local computer
  • Refactored mute logic to support both automatic and manual muting scenarios
  • Integrated the feature into the Remote Access settings UI with appropriate documentation

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
source/_remoteClient/client.py Refactored mute toggle logic and added automatic muting when connecting as leader or switching to local control
source/config/configSpec.py Added new boolean configuration option muteOnLocalControl with default value of False
source/gui/settingsDialogs.py Added checkbox control for the new mute option in Remote Access settings panel
user_docs/en/userGuide.md Added documentation section explaining the new mute option and its behavior
user_docs/en/changes.md Added changelog entry for the new Remote Access muting feature

Comment thread user_docs/en/userGuide.md Outdated
@seanbudd seanbudd added this to the 2025.3 milestone Aug 13, 2025
@seanbudd seanbudd changed the base branch from master to beta August 13, 2025 05:12

@Qchristensen Qchristensen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just made one suggestion to note HOW to manually mute / unmute (by assigning a gesture to it).

Comment thread user_docs/en/userGuide.md Outdated

@Qchristensen Qchristensen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great, thanks Sascha!

@SaschaCowley SaschaCowley enabled auto-merge (squash) August 14, 2025 06:26
@SaschaCowley SaschaCowley merged commit 7d07efa into beta Aug 14, 2025
29 of 30 checks passed
@SaschaCowley SaschaCowley deleted the muteWhenNotSendingKeys branch August 14, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to automatically mute Remote Access when controlling the local computer

4 participants