-
-
Notifications
You must be signed in to change notification settings - Fork 767
Split up chrome tests into logical groups #18502
Copy link
Copy link
Open
Labels
audience/nvda-devPR or issue is relevant to NVDA / Add-on developersPR or issue is relevant to NVDA / Add-on developersp5https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityhttps://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#prioritytriagedHas been triaged, issue is waiting for implementation.Has been triaged, issue is waiting for implementation.
Description
Metadata
Metadata
Assignees
Labels
audience/nvda-devPR or issue is relevant to NVDA / Add-on developersPR or issue is relevant to NVDA / Add-on developersp5https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityhttps://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#prioritytriagedHas been triaged, issue is waiting for implementation.Has been triaged, issue is waiting for implementation.
Related issues, PRs or discussions
Related: #17878
What is the current state of the codebase?
Our chrome tests file is very large, with a large number of helper code, and many tests.
On GitHub actions, we can parallelize our build by splitting up tests.
Why are changes required?
Chrome tests run for about 18min out of the total 30min-35min per build.
Logically it should be split up to make maintaining the tests easier.
What technical changes are required?
To make writing new chrome tests easier, chrome tests should be split up.
Generic helper logic between tests should be split out.
Tests should be grouped logically, with ideally no longer than 5min for each suite.
This would reduce our build time to about 20min per build.
Are the proposed technical changes API breaking?
No
Are there potential risks or issues with the proposed implementation?
No