Update detours#18447
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the bundled Microsoft Detours library from a version that is over two years old to the latest commit, incorporating bug fixes that have been added since October last year. Additionally, it fixes a build configuration issue where LINKFLAGS wasn't being applied to the static Detours library by adding relevant flags to ARFLAGS.
- Updated Detours submodule to latest commit
9764cebcb1a75940e68fa83d6730ffaf0f669401 - Fixed build configuration by moving
/releaseflag to LINKFLAGS and adding appropriate flags to ARFLAGS for static library builds - Updated documentation to reflect the new Detours version and corrected branch reference from "master" to "main"
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| user_docs/en/changes.md | Added changelog entry documenting the Detours update |
| projectDocs/dev/createDevEnvironment.md | Updated documentation with new Detours commit hash |
| nvdaHelper/archBuild_sconscript | Fixed build flags configuration for static libraries |
| include/readme.md | Updated branch reference from "master" to "main" |
| include/detours | Updated submodule pointer to latest Detours commit |
seanbudd
approved these changes
Jul 23, 2025
Member
|
Thanks @LeonarddeR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
Our bundled version of Detours is over two years old. Since October last year, updates have been added that mainly fix bugs.
While at it, I also discovered that LINKFLAGS wasn't used for detours, which is a static lib. I added the relevant flags to ARFLAGS.
Description of user facing changes:
None
Description of developer facing changes:
None
Description of development approach:
Testing strategy:
Tested display model operation in Windows Explorer file properties dialog, as outlined in include/readme.md
Known issues with pull request:
None
Code Review Checklist:
@coderabbitai summary