Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that when typing into an Excel cell, the braille display is updated by manually handling caret movement.
- Imported the braille module.
- Overrode
event_typedCharacterinCellEditto invokebraille.handler.handleCaretMove. - Called the base class implementation after updating braille.
Comments suppressed due to low confidence (2)
source/NVDAObjects/UIA/excel.py:572
- Consider adding a docstring for
event_typedCharacterto explain why this override is necessary and describe its behavior, improving clarity for future maintainers.
def event_typedCharacter(self, ch):
source/NVDAObjects/UIA/excel.py:575
- Add a unit or integration test to verify that typing in a cell triggers
braille.handler.handleCaretMove, ensuring this manual braille update logic is covered by automated tests.
braille.handler.handleCaretMove(self)
seanbudd
reviewed
Jul 2, 2025
seanbudd
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #9749
Summary of the issue:
When typing into a cell in Excel, the braille display is not updated with the new content, due to that control not firing UIA textChange events when updated.
Description of user facing changes:
Description of developer facing changes:
Description of development approach:
Testing strategy:
With a braille display connected to NVDA:
Known issues with pull request:
None specifically. Though it is worth noting there are many other issues remaining with this control, such as braille routing being impossible, and no ability to announce selection changes. However, directly typing is by far the most important, which this pr solves.
Code Review Checklist:
@coderabbitai summary