Skip to content

Add unassigned scripts to open specific settings panels#18313

Merged
seanbudd merged 7 commits into
nvaccess:masterfrom
CyrilleB79:openVision
Jun 24, 2025
Merged

Add unassigned scripts to open specific settings panels#18313
seanbudd merged 7 commits into
nvaccess:masterfrom
CyrilleB79:openVision

Conversation

@CyrilleB79

Copy link
Copy Markdown
Contributor

Link to issue number:

None

Summary of the issue:

NVDA has many commands to open NVDA settings dialog in a specified category, e.g. Speech settings (NVDA+control+V) or Braille settings (unassigned). Some categories are missing and would be needed:

  • Vision settings: useful for visually impaired people, Especially since there is not (yet) scripts to change the individual parameters of this panel (except for screen curtain).
  • Windows OCR settings: opening the settings panel may be more useful than using the "Cycles through the available languages for Windows OCR" for people having many languages in the list
  • Add-on Store: useful for testers
  • Advanced: very useful for NVDA testers, e.g. change Word / Excel UIA settings, etc.

Description of user facing changes:

Commands have been added to open the following panels:

  • Vision
  • Windows OCR
  • Add-on STore
  • Advanced

These commands remain unassigned because they are not expected to be be used by so many people.

For now, no command has been added to open "Document Navigation" panel since it contains only one item. Thus it's more straight forward to assign a script to "Cycles through paragraph navigation styles" and use it. When this panel contains more than 1 item, such command can be added too.

Description of developer facing changes:

N/A

Description of development approach:

Same pattern as existing commands to open other panels.

Testing strategy:

Tested these 4 commands:

  • in normal mode: the panels open
  • in secure mode: Advanced and Add-on Store panel do not open and a message is heard.

Also tested Open Windows OCR command on a system not supporting Windows OCR. Since I have no Windows 8 machine, I have manually forced the if test to simulate a system without Windows OCR.

Known issues with pull request:

  • When opening

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@cary-rowen

Copy link
Copy Markdown
Contributor

I have to thank you for not assigning default gestures to these commands, our gestures are already crowded, and gesture conflicts are becoming more and more common. I would rather have only one command to open the settings dialog and then set the focus to the category list, which is enough, and the other default gestures to open a specific panel appear redundant.

@CyrilleB79 CyrilleB79 marked this pull request as ready for review June 23, 2025 14:24
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner June 23, 2025 14:24
@CyrilleB79 CyrilleB79 requested a review from seanbudd June 23, 2025 14:24
Comment thread source/globalCommands.py Outdated
Comment thread source/gui/__init__.py Outdated
Comment thread source/gui/__init__.py Outdated
Comment thread user_docs/en/changes.md Outdated
@seanbudd seanbudd merged commit 736dd00 into nvaccess:master Jun 24, 2025
4 of 5 checks passed
@github-actions github-actions Bot added this to the 2025.2 milestone Jun 24, 2025
@CyrilleB79 CyrilleB79 deleted the openVision branch June 24, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants