Add unassigned scripts to open specific settings panels#18313
Merged
Conversation
Contributor
|
I have to thank you for not assigning default gestures to these commands, our gestures are already crowded, and gesture conflicts are becoming more and more common. I would rather have only one command to open the settings dialog and then set the focus to the category list, which is enough, and the other default gestures to open a specific panel appear redundant. |
seanbudd
reviewed
Jun 24, 2025
seanbudd
reviewed
Jun 24, 2025
seanbudd
reviewed
Jun 24, 2025
seanbudd
reviewed
Jun 24, 2025
seanbudd
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
NVDA has many commands to open NVDA settings dialog in a specified category, e.g. Speech settings (
NVDA+control+V) or Braille settings (unassigned). Some categories are missing and would be needed:Description of user facing changes:
Commands have been added to open the following panels:
These commands remain unassigned because they are not expected to be be used by so many people.
For now, no command has been added to open "Document Navigation" panel since it contains only one item. Thus it's more straight forward to assign a script to "Cycles through paragraph navigation styles" and use it. When this panel contains more than 1 item, such command can be added too.
Description of developer facing changes:
N/A
Description of development approach:
Same pattern as existing commands to open other panels.
Testing strategy:
Tested these 4 commands:
Also tested Open Windows OCR command on a system not supporting Windows OCR. Since I have no Windows 8 machine, I have manually forced the if test to simulate a system without Windows OCR.
Known issues with pull request:
Code Review Checklist:
@coderabbitai summary