Skip to content

Use devenv app module for SQL Server Management Studio#18176

Merged
seanbudd merged 4 commits into
nvaccess:masterfrom
LeonarddeR:ssms
Jun 2, 2025
Merged

Use devenv app module for SQL Server Management Studio#18176
seanbudd merged 4 commits into
nvaccess:masterfrom
LeonarddeR:ssms

Conversation

@LeonarddeR

Copy link
Copy Markdown
Collaborator

Link to issue number:

None

Summary of the issue:

Microsoft SQL Server Management Studio has always been based on Visual Studio, though this was never reflected in NVDA"s use of the devenv submodule. This becomes more prevalent since SSMS version 21, which upgrades its internals from VS 2017 to VS 2022. NVDA requires a Visual Studio specific tweak to properly respect the line number reporting setting in the query editor.

Description of user facing changes

NVDA no longer ignores the line number reporting setting in SSMS 21.

Description of development approach

  1. Add a mapping to EXECUTABLE_NAMES_TO_APP_MODS
  2. Refactored _getExecutableFileInfo in such a way that the executable path of the current process can now be fetched separately.
  3. When using SSMS, base VS Major and VS Minor on the product version of vssln.dll, which has been found in installations of SSMS 20 and 21. If we don't, the product version of SSMS is used, which differs from the internal VS version.

Testing strategy:

  1. Tested that vsMajor and vsMinor are properly recognised and that the app module can access the Visual Studio object model in SSMS.
  2. Tested that line numbers are no longer reported erroneously.

Known issues with pull request:

None known

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@LeonarddeR LeonarddeR requested a review from a team as a code owner May 28, 2025 06:32
@LeonarddeR LeonarddeR requested a review from SaschaCowley May 28, 2025 06:32

@SaschaCowley SaschaCowley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny request here

Comment thread source/appModules/devenv.py
Co-authored-by: Sascha Cowley <16543535+SaschaCowley@users.noreply.github.com>

@SaschaCowley SaschaCowley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @LeonarddeR

@seanbudd seanbudd merged commit 97b3f3b into nvaccess:master Jun 2, 2025
15 checks passed
@github-actions github-actions Bot added this to the 2025.2 milestone Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants