Use devenv app module for SQL Server Management Studio#18176
Merged
Conversation
SaschaCowley
requested changes
May 30, 2025
SaschaCowley
left a comment
Member
There was a problem hiding this comment.
Just a tiny request here
Co-authored-by: Sascha Cowley <16543535+SaschaCowley@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
Microsoft SQL Server Management Studio has always been based on Visual Studio, though this was never reflected in NVDA"s use of the devenv submodule. This becomes more prevalent since SSMS version 21, which upgrades its internals from VS 2017 to VS 2022. NVDA requires a Visual Studio specific tweak to properly respect the line number reporting setting in the query editor.
Description of user facing changes
NVDA no longer ignores the line number reporting setting in SSMS 21.
Description of development approach
EXECUTABLE_NAMES_TO_APP_MODS_getExecutableFileInfoin such a way that the executable path of the current process can now be fetched separately.Testing strategy:
Known issues with pull request:
None known
Code Review Checklist:
@coderabbitai summary