Skip to content

When using Word shortcuts to change view type, report the new view#18091

Merged
SaschaCowley merged 3 commits into
nvaccess:masterfrom
CyrilleB79:reportViewType
May 16, 2025
Merged

When using Word shortcuts to change view type, report the new view#18091
SaschaCowley merged 3 commits into
nvaccess:masterfrom
CyrilleB79:reportViewType

Conversation

@CyrilleB79

Copy link
Copy Markdown
Contributor

Link to issue number:

None

Summary of the issue:

Word has shortcuts to change view type (page, outline, etc.)

Description of user facing changes

When using Word shortcuts to change the view type, the new view type is reported. The following shortcuts are supported:

  • control+alt+p: page view
  • control+alt+o: outline view

Words has also a shortcut control+alt+n to switch to draft (normal) mode. Since it is overridden by NVDA's launch shortcut, it is not supported in this PR. Changing NVDA's well known default launch shortcut to free Word's native control+alt+n is not worth it.

Description of development approach

Usual pattern for Word toggle scripts using the object model.

Testing strategy:

Manuel test in Word (2021 LTSC).

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@SaschaCowley SaschaCowley added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label May 12, 2025
@CyrilleB79 CyrilleB79 marked this pull request as ready for review May 13, 2025 13:54
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner May 13, 2025 13:54
@CyrilleB79 CyrilleB79 requested a review from SaschaCowley May 13, 2025 13:54
Comment thread user_docs/en/changes.md Outdated
@SaschaCowley SaschaCowley merged commit 57f5cf5 into nvaccess:master May 16, 2025
15 checks passed
@github-actions github-actions Bot added this to the 2025.2 milestone May 16, 2025
@CyrilleB79 CyrilleB79 deleted the reportViewType branch May 16, 2025 08:50
@adlevision

Copy link
Copy Markdown

The 2025.2 release notes said this had been remedied, but it still isn't announcing the view change for me (2025.2-2025.3 beta 3). Word version 25018 build 16.0.19127.20082 64-bit. .

@CyrilleB79

Copy link
Copy Markdown
Contributor Author

Please open a new issue, filling the template completely, so that we can reproduce what you are doing and how. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants