Skip to content

Update SCons 4.8.1 to 4.9.1#18069

Merged
seanbudd merged 2 commits into
nvaccess:masterfrom
dpy013:scons4.8.1to4.9.1
Jun 10, 2025
Merged

Update SCons 4.8.1 to 4.9.1#18069
seanbudd merged 2 commits into
nvaccess:masterfrom
dpy013:scons4.8.1to4.9.1

Conversation

@dpy013

@dpy013 dpy013 commented May 8, 2025

Copy link
Copy Markdown
Contributor

Link to issue number:

none

Summary of the issue:

Update SCons from 4.8.1 to 4.9.1 to apply the latest security fixes.
https://github.com/SCons/scons/releases/tag/4.9.1

Description of user facing changes

none

Description of development approach

The Scons version in pyproject.toml and uv.lock has been updated to the latest stable version 4.9.1.

Testing strategy:

Tested the compilation in localization and it passes, depending on whether the ci can be compiled.

Known issues with pull request:

Not yet.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@dpy013 dpy013 requested a review from a team as a code owner May 8, 2025 03:37
@dpy013 dpy013 requested a review from SaschaCowley May 8, 2025 03:37
@dpy013 dpy013 marked this pull request as draft May 8, 2025 03:38
@dpy013 dpy013 closed this May 8, 2025
@dpy013 dpy013 reopened this May 8, 2025
@dpy013 dpy013 changed the title try Update SCons 4.8.1to4.9.1 Update SCons 4.8.1to4.9.1 May 8, 2025
@dpy013 dpy013 marked this pull request as ready for review May 8, 2025 05:33
@LeonarddeR

Copy link
Copy Markdown
Collaborator

Can we please wait for SCons/scons#4717 to end up in an official release?

@dpy013 dpy013 marked this pull request as draft May 8, 2025 22:37
@dpy013

dpy013 commented May 8, 2025

Copy link
Copy Markdown
Contributor Author

Can we please wait for SCons/scons#4717 to end up in an official release?
Yes, I'll set this pr to draft and I'll keep an eye on the sconsGitHub repository for developments.
thanks

@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit b74718b29a

@gerald-hartig gerald-hartig changed the title Update SCons 4.8.1to4.9.1 Update SCons 4.8.1 to 4.9.1 May 12, 2025
@SaschaCowley SaschaCowley added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label May 12, 2025
@LeonarddeR

Copy link
Copy Markdown
Collaborator

@dpy013 It is not necessary to merge in master as often as you do. It is safe to return back to the branch as soon as a new version of SCons is released.

@seanbudd

seanbudd commented Jun 6, 2025

Copy link
Copy Markdown
Member

It's probably fine to get this ready and merge this. We don't know when the next release will be, and there's no real harm in updating this in the mean time. we'd like to get this merged before we approach a 2025.2 beta.

@seanbudd seanbudd added the merge-early Merge Early in a developer cycle label Jun 6, 2025
@dpy013 dpy013 marked this pull request as ready for review June 6, 2025 07:57
@dpy013

dpy013 commented Jun 6, 2025

Copy link
Copy Markdown
Contributor Author
      The PR has been redone using the latest commit and can be reviewed and merged by NVAccess at any time.

@seanbudd seanbudd merged commit a1ad46c into nvaccess:master Jun 10, 2025
3 of 5 checks passed
@github-actions github-actions Bot added this to the 2025.2 milestone Jun 10, 2025
@dpy013 dpy013 deleted the scons4.8.1to4.9.1 branch June 10, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. merge-early Merge Early in a developer cycle

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants