Skip to content

AdobeAcrobat: support custom Microsoft Office mathml attribute.#18056

Merged
seanbudd merged 2 commits into
betafrom
acrobatOfficeMath
May 6, 2025
Merged

AdobeAcrobat: support custom Microsoft Office mathml attribute.#18056
seanbudd merged 2 commits into
betafrom
acrobatOfficeMath

Conversation

@michaelDCurran

@michaelDCurran michaelDCurran commented May 5, 2025

Copy link
Copy Markdown
Member

Link to issue number:

None
Blocked by #17984

Summary of the issue:

In #17276, NVDA now treats the value of formular nodes in Adobe Acrobat as mathml, with out any real validation.
In PDF 2.0 documents, this is no doubt an okay assumption, but for PDF 1.7 documents generated by Microsoft Word, this is now causing Microsoft word generated math speech alternative text to be processed by mathCAT, resulting in broken or junk navigation, as Microsoft Word is exposing its math speech text as the value of the node.
However, at the same time Microsoft has also introduced a new custom mathml attribute it is exposing on formula nodes in PDFs generated from Microsoft Word, that contains real mathMl which is suitable for MathCAT.
NVDA should make use of this new custom attribute if it exists.

Description of user facing changes

In Adobe Acrobat, NVDA can now read and interact with Math equations in PDF documents generated by Microsoft word.

Description of development approach

AcrobatNode NVDAObject's mathml property: first try and fetch Microsoft Office's custom mathMl custom attribute if it exists. Otherwise fallback to using the node's value or descendants.

Testing strategy:

Opened several PDF documents generated by icrosoft ord that contain math equations. Ensured that they could be read and interactive with using MathCAT.

Known issues with pull request:

None known.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@michaelDCurran michaelDCurran requested a review from a team as a code owner May 5, 2025 21:14
@seanbudd seanbudd added this to the 2025.1 milestone May 5, 2025
@seanbudd

seanbudd commented May 5, 2025

Copy link
Copy Markdown
Member

how does this relate to #17984?

@michaelDCurran

michaelDCurran commented May 6, 2025 via email

Copy link
Copy Markdown
Member Author

@seanbudd

seanbudd commented May 6, 2025

Copy link
Copy Markdown
Member

Can you resolve conflicts? I've merged that PR

@michaelDCurran

Copy link
Copy Markdown
Member Author

I've fixed up conflicts now that #17984 is merged.

@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit eaf8b84603

Comment thread user_docs/en/changes.md
@seanbudd seanbudd merged commit 8efed37 into beta May 6, 2025
4 of 5 checks passed
@seanbudd seanbudd deleted the acrobatOfficeMath branch May 6, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants