Simplify getDocFilePath function#17911
Merged
Merged
Conversation
Contributor
Author
|
@seanbudd or @SaschaCowley: with this PR, Is this considered API breaking? And if yes, should I re-target to beta? |
Member
|
I think yes, let's retarget to beta for safety |
See test results for failed build of commit 3eddf8d7b8 |
seanbudd
reviewed
Apr 8, 2025
seanbudd
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None; related to #13333.
Summary of the issue:
The file
th\key commands.txtwas an old outdated that was removed during the migration to Crowdin. Now the local documentations do not contain any old txt file, butgetDocFilePathhad still some unused code to handle these files.Description of user facing changes
None.
Description of development approach
Remove dead code in both
getDocFilePathfunctions.While at it, updated
.git-ignoreto also ignore all the.mdfiles that are generated when building the documentation (scons user_docs), since the source strings are now in .xliff files.Testing strategy:
installer.getDocFilePathwith the same files.runnvda --launcher) and from NVDA menuKnown issues with pull request:
None
Code Review Checklist:
@coderabbitai summary