Skip to content

Word UIA: Support native table extended navigation commands#17867

Merged
SaschaCowley merged 6 commits into
nvaccess:masterfrom
CyrilleB79:wordTableNavUIA
Apr 4, 2025
Merged

Word UIA: Support native table extended navigation commands#17867
SaschaCowley merged 6 commits into
nvaccess:masterfrom
CyrilleB79:wordTableNavUIA

Conversation

@CyrilleB79

@CyrilleB79 CyrilleB79 commented Mar 28, 2025

Copy link
Copy Markdown
Contributor

Link to issue number:

None

Summary of the issue:

In word, native extended table navigation commands alt+home, alt+end, alt+pageUp and alt+pageDown are report their result (i.e. the content of the landing cell) when using legacy document access, but not when using UIA.

Description of user facing changes

In Word with UIA, when using the native extended table navigation commands alt+home, alt+end, alt+pageUp and alt+pageDown, the landing cell will now be reported.

Description of development approach

  • Factorize the script for this commands to use it for legacy as well as for UIA.
  • Create separate _inTable methods for UIA and for legacy.
  • For UIA text info's expand method, implement the support for cell unit.

Testing strategy:

Manual testing for both UIA and legacy.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@CyrilleB79 CyrilleB79 marked this pull request as ready for review March 28, 2025 13:23
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner March 28, 2025 13:23
@CyrilleB79 CyrilleB79 requested a review from SaschaCowley March 28, 2025 13:23
@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Apr 1, 2025
Comment thread source/documentBase.py Outdated
Comment thread user_docs/en/changes.md Outdated
CyrilleB79 and others added 2 commits April 1, 2025 08:40
Co-authored-by: Sascha Cowley <16543535+SaschaCowley@users.noreply.github.com>
Comment thread source/NVDAObjects/IAccessible/winword.py Outdated
Comment thread source/documentBase.py Outdated
@SaschaCowley SaschaCowley merged commit b048dbd into nvaccess:master Apr 4, 2025
@github-actions github-actions Bot added this to the 2025.1 milestone Apr 4, 2025
@CyrilleB79 CyrilleB79 deleted the wordTableNavUIA branch April 4, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants