-
-
Notifications
You must be signed in to change notification settings - Fork 784
Feature flags may not reside in config.ConfigManager.BASE_ONLY_SECTIONS #17723
Copy link
Copy link
Open
Labels
audience/nvda-devPR or issue is relevant to NVDA / Add-on developersPR or issue is relevant to NVDA / Add-on developersfeature/configurationMaking NVDA more configurable.Making NVDA more configurable.good first issuegithub features these at https://github.com/nvaccess/nvda/contributegithub features these at https://github.com/nvaccess/nvda/contributep5https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityhttps://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#prioritytriagedHas been triaged, issue is waiting for implementation.Has been triaged, issue is waiting for implementation.
Description
Metadata
Metadata
Assignees
Labels
audience/nvda-devPR or issue is relevant to NVDA / Add-on developersPR or issue is relevant to NVDA / Add-on developersfeature/configurationMaking NVDA more configurable.Making NVDA more configurable.good first issuegithub features these at https://github.com/nvaccess/nvda/contributegithub features these at https://github.com/nvaccess/nvda/contributep5https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityhttps://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#prioritytriagedHas been triaged, issue is waiting for implementation.Has been triaged, issue is waiting for implementation.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Steps to reproduce:
Add a Feature Flag to the general config section as in #17651
Actual behavior:
Feature flags in base only sections are not supported. Feature flags rely on support in
config.AggregatedSectionto validate the flag after setting it. This doesn't work in the base only sections, whereconfigobj.Sectionis used.Expected behavior:
Feature flags in base only config sections work as expected.