Manually refresh the recognized content with NVDA+f5 in a recognition result#17715
Merged
Conversation
See test results for failed build of commit 3073ea0186 |
f5 in a recognition resultNVDA+f5 in a recognition result
See test results for failed build of commit 5a83e133c5 |
seanbudd
reviewed
Feb 25, 2025
Qchristensen
approved these changes
Feb 25, 2025
Qchristensen
left a comment
Member
There was a problem hiding this comment.
Reads well (with Sean's suggestion)
seanbudd
approved these changes
Feb 25, 2025
seanbudd
pushed a commit
that referenced
this pull request
Feb 25, 2025
…on result (#17715) Summary of the issue: Even if not using the automatic refresh of the content recognition, the user may want to update the recognized content once manually. Today, they needs to close the recog result and perform a recognition again. Description of user facing changes In a result of content recognition, the user can now press NVDA+f5 to refresh the result of recognized content. This refresh gesture is the same as the one to refresh the content of virtual buffers. Description of development approach In RefreshableRecogResultNVDAObject, added a script to refresh the recognition result. If automatic recognition is enabled, the script reports an error message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
Even if not using the automatic refresh of the content recognition, the user may want to update the recognized content once manually. Today, they needs to close the recog result and perform a recognition again.
Description of user facing changes
In a result of content recognition, the user can now press
NVDA+f5to refresh the result of recognized content. This refresh gesture is the same as the one to refresh the content of virtual buffers.Description of development approach
In
RefreshableRecogResultNVDAObject, added a script to refresh the recognition result. If automatic recognition is enabled, the script reports an error message.Testing strategy:
Manual test of the script with and without auto-refresh enabled.
Known issues with pull request:
None
Code Review Checklist:
@coderabbitai summary