Skip to content

Fix braille table loading with debug logging enabled and/or add-ons disabled#17565

Merged
seanbudd merged 2 commits into
nvaccess:masterfrom
LeonarddeR:unboundLocalFix
Dec 30, 2024
Merged

Fix braille table loading with debug logging enabled and/or add-ons disabled#17565
seanbudd merged 2 commits into
nvaccess:masterfrom
LeonarddeR:unboundLocalFix

Conversation

@LeonarddeR

Copy link
Copy Markdown
Collaborator

Link to issue number:

None

Summary of the issue:

When custom braille tables are available in the manifest of the scratchpad and NVDA starts with debug logging enabled, it will raise an unbound local error due to a wrong logging statement. This actually revealed another bug, namely that scratchpad braille tables weren't ignored when addons are disabled.

Description of user facing changes

No longer an error in this specific case. Furthermore, custom braille tables from the scratchpad wil be disabled when addons are.

Description of development approach

  1. Fixed the debug logging statement
  2. in brailleTables.initialize, return early when add-ons disabled or when appX.

Testing strategy:

Tested from source that the error no longer occurs and that scratchpad tables are no longer loaded

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@LeonarddeR LeonarddeR requested a review from a team as a code owner December 21, 2024 08:25
@LeonarddeR LeonarddeR changed the title Fix braille table loading with debug logging enabled Fix braille table loading with debug logging enabled and/or add-ons disabled Dec 21, 2024
@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit 2a0c5cc8a1

@seanbudd

Copy link
Copy Markdown
Member

Thanks @LeonarddeR

@seanbudd seanbudd merged commit 400facc into nvaccess:master Dec 30, 2024
@github-actions github-actions Bot added this to the 2025.1 milestone Dec 30, 2024
@LeonarddeR LeonarddeR deleted the unboundLocalFix branch August 23, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants