Fix braille table loading with debug logging enabled and/or add-ons disabled#17565
Merged
Conversation
…t and running with debug logging
8eab599 to
80b6754
Compare
See test results for failed build of commit 2a0c5cc8a1 |
seanbudd
approved these changes
Dec 30, 2024
Member
|
Thanks @LeonarddeR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
When custom braille tables are available in the manifest of the scratchpad and NVDA starts with debug logging enabled, it will raise an unbound local error due to a wrong logging statement. This actually revealed another bug, namely that scratchpad braille tables weren't ignored when addons are disabled.
Description of user facing changes
No longer an error in this specific case. Furthermore, custom braille tables from the scratchpad wil be disabled when addons are.
Description of development approach
brailleTables.initialize, return early when add-ons disabled or when appX.Testing strategy:
Tested from source that the error no longer occurs and that scratchpad tables are no longer loaded
Known issues with pull request:
None
Code Review Checklist:
@coderabbitai summary