Fix audio output device selection#17532
Merged
Merged
Conversation
seanbudd
reviewed
Dec 16, 2024
seanbudd
reviewed
Dec 16, 2024
seanbudd
approved these changes
Dec 17, 2024
SaschaCowley
commented
Dec 17, 2024
Contributor
|
While we're removing things, is it worth renaming WasapiWavePlayer to just WavePlayer as well, thus removing the redundant alias? The fact that it's called WasapiWavePlayer was an internal implementation detail necessitated by the coexistence of WinMM and WASAPI. In hindsight, I probably should have underscore prefixed it in the first place. |
Member
Author
|
@jcsteh yes, I think we should. I'm planning to do this in the new year. |
Member
|
@SaschaCowley - I think this also missed being announced on the API mailing list |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #17530
Summary of the issue:
With the switch to exclusively WASAPI, selecting among more than 2 output devices did not work properly.
Description of user facing changes
Selection of output devices should now be more reliable.
Description of development approach
Fixed up the check for whether the selected device is the default output device. Also removed some unneeded initialisation parameters and constants.
Testing strategy:
Manually tested switching between 3 output devices (plus default), with various devices set as the Windows and NVDA default.
Known issues with pull request:
Some legacy winmm code remains, but this will be removed once SAPI4 support has been fixed.
Code Review Checklist:
@coderabbitai summary