-
-
Notifications
You must be signed in to change notification settings - Fork 783
Switch to using endpoint IDs for identifying selected output device in user configuration #17497
Copy link
Copy link
Closed
Labels
api-breaking-changecomponent/audioNVDA's audio output (nvWave, issues with usb audio etc).NVDA's audio output (nvWave, issues with usb audio etc).p2https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityhttps://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityrelease/blockingthis issue blocks the milestone releasethis issue blocks the milestone releasetriagedHas been triaged, issue is waiting for implementation.Has been triaged, issue is waiting for implementation.
Milestone
Metadata
Metadata
Assignees
Labels
api-breaking-changecomponent/audioNVDA's audio output (nvWave, issues with usb audio etc).NVDA's audio output (nvWave, issues with usb audio etc).p2https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityhttps://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityrelease/blockingthis issue blocks the milestone releasethis issue blocks the milestone releasetriagedHas been triaged, issue is waiting for implementation.Has been triaged, issue is waiting for implementation.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Is your feature request related to a problem? Please describe.
Currently, users' selection of which audio output device to use is stored in the config by saving the device's friendly name to their config, then enumerating all output devices on the system, and matching against the first device with the same friendly name. This presents a number of issues:
Describe the solution you'd like
After winmm support is removed (#17496 ), switch to using endpoint IDs for identification. This also has a number of drawbacks:
Describe alternatives you've considered
Keep on identifying devices by their friendly names.
Additional context
This will require rewriting some of NVDAHelper, as our C++ WASAPI code assumes that what we give it to identify devices is the device's friendly name. Would also require changes to the settings GUI code, and nvwave.