Allow associating ComboBoxes to labels#17476
Merged
Merged
Conversation
CyrilleB79
reviewed
Dec 3, 2024
CyrilleB79
reviewed
Dec 3, 2024
SaschaCowley
requested changes
Dec 4, 2024
SaschaCowley
requested changes
Dec 10, 2024
SaschaCowley
left a comment
Member
There was a problem hiding this comment.
Should an entry be added to changes for developers?
seanbudd
commented
Dec 10, 2024
Co-authored-by: Sascha Cowley <16543535+SaschaCowley@users.noreply.github.com>
Member
|
@seanbudd can you add a note to the changelog please? I feel like this is a useful addition for devs to know about |
Member
Author
|
@SaschaCowley - done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
We need to add support for associating labels to a wx.ComboBox using
gui.guiHelper.associateElements.Additionally, the association for
wx.StaticTextandwx.CheckBoxwas undocumented in the functions docstring.Description of user facing changes
Description of development approach
Added TypeVars and rewrote type hinting to be more specific, clear and self-documenting.
Added support to ComboBoxes for horizontal controls.
Testing strategy:
Tested with NVDA remote
Known issues with pull request:
Code Review Checklist:
@coderabbitai summary