Skip to content

Fix link URL reporting in Excel cells#17362

Merged
seanbudd merged 5 commits into
nvaccess:masterfrom
CyrilleB79:excelLink
Nov 8, 2024
Merged

Fix link URL reporting in Excel cells#17362
seanbudd merged 5 commits into
nvaccess:masterfrom
CyrilleB79:excelLink

Conversation

@CyrilleB79

Copy link
Copy Markdown
Contributor

Link to issue number:

None

Summary of the issue:

In Excel, when a cell contains a link, using the report link command (NVDA+k) reports "Blank" instead of the URL.

Description of user facing changes

When using NVDA+K in an Excel cell, the correct URL is now reported (with simple or double press).

Description of development approach

  • Use Excel object model to get the URL of the link.
  • Put the MsoHyperlink enumeration in a separate file since it is now used by both Word and Excel.

Testing strategy:

Manual tests:

  • Confirmed that link reporting in Excel (single or double press), as well as in Word (legacy) is working correctly.
  • Confirmed that trying to report the URL of a link where there is no link behaves as expected.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@CyrilleB79 CyrilleB79 marked this pull request as ready for review November 4, 2024 15:02
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner November 4, 2024 15:02

@SaschaCowley SaschaCowley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @CyrilleB79

Comment thread source/NVDAObjects/window/_msOffice.py Outdated
Comment thread user_docs/en/changes.md Outdated
@AppVeyorBot

Copy link
Copy Markdown
  • PASS: Translation comments check.
  • PASS: License check.
  • PASS: Unit tests.
  • PASS: Lint check.
  • FAIL: System tests (tags: installer NVDA). See test results for more information.
  • Build (for testing PR): https://ci.appveyor.com/api/buildjobs/1xpx6fiprhj47tji/artifacts/output/l10nUtil.exe nvda_snapshot_pr17362-34502,431c1626.exe
  • CI timing (mins):
    INIT 0.0,
    INSTALL_START 1.3,
    INSTALL_END 1.1,
    BUILD_START 0.0,
    BUILD_END 25.7,
    TESTSETUP_START 0.0,
    TESTSETUP_END 0.4,
    TEST_START 0.0,
    TEST_END 18.9,
    FINISH_END 0.2

See test results for failed build of commit 431c162634

@seanbudd seanbudd merged commit 32f8fb1 into nvaccess:master Nov 8, 2024
@github-actions github-actions Bot added this to the 2025.1 milestone Nov 8, 2024
@CyrilleB79 CyrilleB79 deleted the excelLink branch November 8, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants