Comment 1 by jteh on 2011-08-21 18:41
Thanks for the contribution!

Here is some code review. Please address these comments and update the module.

First, the header comments need to be changed to conform with the rest of the NVDA code. Something like this:

#appModules/vipmud.py
#A part of NonVisual Desktop Access (NVDA)
#Copyright (C) 2011 Willem Venter and Rynhardt Kruger
#This file is covered by the GNU General Public License.
#See the file COPYING for more details.

import speech
from keyboardHandler import KeyboardInputGesture

Unused imports. Please remove.

  def chooseNVDAObjectOverlayClasses(self, obj, clsList):
      if controlTypes.STATE_READONLY in obj._get_states():

Is there any reason you're using _get_states here instead of the property? If not, please change this to obj.states.

class MudText(edit.Edit):
  def event_valueChange(self):

...

      for i in range(0, len(lines)):
          lines[          if len(lines[i](i].strip()
)) >0:self.appModule.msgs.insert(0, lines[```
There are a few issues here:
 * ```lines[i](i])
).strip()``` will have no effect. strip() returns the stripped string, as opposed to stripping the string on which it is called. Strings are immutable.
 * ```if len(s) > 0``` often makes more sense as just ```if s```.
 * It's more elegant to iterate using a list iterator here.
I'd change this code to the following:

    for line in lines:
        line = line.strip()
        if not line:
            continue
        self.appModule.msgs.insert(0, line)

  if len(self.appModule.msgs) > self.appModule.historyLength:

      self.appModule.msgs =self.appModule.msgs[```

This can be done far more efficiently:

        del self.appModule.msgs[self.appModule.historyLength:](0:self.appModule.historyLength]
>)

Note that you don't even need the if check, as it's not an error to delete a slice which doesn't exist; the slice is just considered empty.

Thanks again.

Uh oh!

Vip mud script #1728

Description

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions