Skip to content

Update wxPython to 4.2.2, using 32-bit wheel hosted on PyPI#17181

Merged
seanbudd merged 8 commits into
nvaccess:masterfrom
dpy013:fix17175
Sep 19, 2024
Merged

Update wxPython to 4.2.2, using 32-bit wheel hosted on PyPI#17181
seanbudd merged 8 commits into
nvaccess:masterfrom
dpy013:fix17175

Conversation

@dpy013

@dpy013 dpy013 commented Sep 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Link to issue number:

fix #17175

Summary of the issue:

Update wxPython to 4.2.2, using 32-bit wheel hosted on PyPI

Description of user facing changes

Not yet.

Description of development approach

Replace the wx python version of the requirements file with pip's
and tested it with a locally compiled build!

Testing strategy:

Need to watch appveyor build after compilation

Known issues with pull request:

Nothing yet.

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary
Here are the test logs for the NVDA compilation builds
nvda.log

@dpy013 dpy013 requested a review from a team as a code owner September 16, 2024 08:07
@dpy013 dpy013 requested a review from SaschaCowley September 16, 2024 08:07
@dpy013 dpy013 marked this pull request as draft September 16, 2024 08:09
@dpy013 dpy013 marked this pull request as ready for review September 16, 2024 08:24
@dpy013

dpy013 commented Sep 16, 2024

Copy link
Copy Markdown
Contributor Author

Tested wx-python 4.2.2 with pr17181-34014, who has the same messages as in the test log above.
No error messages were reported.
nvda.log

@CyrilleB79

CyrilleB79 commented Sep 16, 2024

Copy link
Copy Markdown
Contributor

I'd say that tests should be more thourough:

  • Try to open and validate many dialogs off different types
  • Have a visual confirmation that the layout of the main dialogs (if not all) has not been altered.

@ABuffEr

ABuffEr commented Sep 16, 2024

Copy link
Copy Markdown
Contributor

Hi,
check also the symbol/punctuation dialog and emoji representation, that is the main reason we have used that alpha of wxPython, see #15714.

@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Sep 17, 2024
@seanbudd

seanbudd commented Sep 17, 2024

Copy link
Copy Markdown
Member

Can you please make sure to update nvda-misc-deps to remove the wxPython wheel

SaschaCowley
SaschaCowley reviewed Sep 17, 2024
View reviewed changes
Comment thread user_docs/en/changes.md Outdated
dpy013 and others added 2 commits September 17, 2024 18:58
@dpy013
Merge remote-tracking branch 'remotes/origin/master' into fix17175
e02dfdd
@dpy013 @SaschaCowley
Update user_docs/en/changes.md
7377ea8 
Co-authored-by: Sascha Cowley <16543535+SaschaCowley@users.noreply.github.com>
@dpy013

dpy013 commented Sep 17, 2024

Copy link
Copy Markdown
Contributor Author

Hello everyone,
I wish you all a happy Mid-Autumn Festival. I have completed all the changes mentioned above.
nvaccess/nvda-misc-deps#34

@AppVeyorBot

AppVeyorBot commented Sep 18, 2024

Copy link
Copy Markdown

See test results for failed build of commit 5c057cbe25

@seanbudd seanbudd merged commit 88ecc87 into nvaccess:master Sep 19, 2024
@github-actions github-actions Bot added this to the 2025.1 milestone Sep 19, 2024
@seanbudd seanbudd mentioned this pull request Sep 19, 2024
Merged
seanbudd pushed a commit to nvaccess/nvda-misc-deps that referenced this pull request Sep 19, 2024
@dpy013
Remove wxPython (#34)
2594888 
follow up to PR nvaccess/nvda#17181 which updated wxPython to 4.2.2, using 32-bit wheel hosted on PyPI, rather than a custom build
@dpy013 dpy013 deleted the fix17175 branch September 19, 2024 06:15
@seanbudd seanbudd mentioned this pull request Nov 14, 2024
Closed
5 tasks
@nishimotz nishimotz mentioned this pull request Apr 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SaschaCowley SaschaCowley SaschaCowley approved these changes

Assignees

No one assigned

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Milestone

2025.1

Development

Successfully merging this pull request may close these issues.

Update wxPython to 4.2.2, using 32-bit wheel hosted on PyPI

6 participants

@dpy013 @CyrilleB79 @ABuffEr @seanbudd @AppVeyorBot @SaschaCowley