Skip to content

Upgrade nh3 from 0.2.17 to 0.2.18#17020

Merged
seanbudd merged 2 commits into
nvaccess:masterfrom
dpy013:nh3-upgrade
Aug 19, 2024
Merged

Upgrade nh3 from 0.2.17 to 0.2.18#17020
seanbudd merged 2 commits into
nvaccess:masterfrom
dpy013:nh3-upgrade

Conversation

@dpy013

@dpy013 dpy013 commented Aug 19, 2024 •
edited by seanbudd
Loading

Copy link
Copy Markdown
Contributor

Update Details

nh3 0.2.18 mainly updates the following dependencies:

  • Bump pyo3 from 0.21.0 to 0.21.1
  • Bump pyo3 from 0.21.1 to 0.21.2
  • Bump pyo3 from 0.21.2 to 0.22.0
    View the changelog from here

Link to issue number:

none

Summary of the issue:

nh3 0.2.18 This is a dependency update version with no functional changes.

Description of user facing changes

No user changes

Description of development approach

Updated requirements.txt to use latest nh3 0.2.18

Testing strategy:

has been compiled and tested using the local environment.
You need to use appveyor to compile the test.

Known issues with pull request:

none

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

Summary by CodeRabbit

  • Chores
    • Updated the nh3 package version to improve performance and potential bug fixes.

@dpy013 dpy013 requested a review from a team as a code owner August 19, 2024 00:24
@dpy013 dpy013 requested a review from SaschaCowley August 19, 2024 00:24
@coderabbitai

coderabbitai Bot commented Aug 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The recent update involves a minor version change in the requirements.txt file, specifically upgrading the nh3 package from version 0.2.17 to 0.2.18. This update is expected to bring potential bug fixes and performance improvements without altering the overall functionality or control flow of the application.

Changes

File Change Summary
requirements.txt Updated nh3 package version from 0.2.17 to 0.2.18

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@seanbudd seanbudd changed the title Upgrade:nh30.2.17 to 0.2.18 Upgrade nh3 from 0.2.17 to 0.2.18 Aug 19, 2024
@seanbudd seanbudd merged commit 8bc6f52 into nvaccess:master Aug 19, 2024
@github-actions github-actions Bot added this to the 2024.4 milestone Aug 19, 2024
@dpy013 dpy013 deleted the nh3-upgrade branch August 19, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanbudd seanbudd seanbudd approved these changes

@SaschaCowley SaschaCowley Awaiting requested review from SaschaCowley SaschaCowley is a code owner automatically assigned from nvaccess/developers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2024.4

Development

Successfully merging this pull request may close these issues.

2 participants

@dpy013 @seanbudd