-
-
Notifications
You must be signed in to change notification settings - Fork 784
Reconsider fast_diff_match_path license violation workaround #16633
Copy link
Copy link
Closed
Labels
audience/nvda-devPR or issue is relevant to NVDA / Add-on developersPR or issue is relevant to NVDA / Add-on developersp5https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityhttps://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#prioritytriagedHas been triaged, issue is waiting for implementation.Has been triaged, issue is waiting for implementation.
Metadata
Metadata
Assignees
Labels
audience/nvda-devPR or issue is relevant to NVDA / Add-on developersPR or issue is relevant to NVDA / Add-on developersp5https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityhttps://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#prioritytriagedHas been triaged, issue is waiting for implementation.Has been triaged, issue is waiting for implementation.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Is your feature request related to a problem? Please describe.
I have found some oddities in
UnicodeNormalizationOffsetConverterthat are related to difflib doing very odd things on the character level. I haven't been able to reproduce this with non-private content, though.Ideally I'd move to fast_diff_match_patch, but I don't want to change nvda_DMP just for this. This made me question the decision to create NVDA_DMP in the first place. Has this been discussed extensively in the past and if so, where?
Also note that from a python console, it is still possible to import
fast_diff_match_patch. I wonder if this is actually allowed within the licensing provisions. There is some inconsistency here.Describe the solution you'd like
I know about license compatibilities, but I'm also reading from Apache:
Long story short:
By the way, the license actually allows us to stretch the term plugin in the developer guide to such an extent that we can also classify parts of the core that stand alone but are not necessarily globalPlugins as plugins, making them subject to this license provision.
Describe alternatives you've considered
Refactor nvda_dmp in such a way that it returns the full diff, rather than only insertions.
Any thoughts @codeofdusk, @Danstiv
Originally posted by @LeonarddeR in #11548 (comment)