Skip to content

Use fixed width font in the log viewer and the Python console#16321

Merged
seanbudd merged 9 commits into
nvaccess:masterfrom
CyrilleB79:logFont
May 7, 2024
Merged

Use fixed width font in the log viewer and the Python console#16321
seanbudd merged 9 commits into
nvaccess:masterfrom
CyrilleB79:logFont

Conversation

@CyrilleB79

@CyrilleB79 CyrilleB79 commented Mar 18, 2024

Copy link
Copy Markdown
Contributor

Link to issue number:

None

Summary of the issue:

Errors in the source code are indicated visually by "^" characters and has become more precise with Python 3.11.
However, the characters used in log viewer or python console have not a fixed width so:

  • visually, the wrong place of the source code is indicated
  • for blind people, going on the error marker ("^" characters) and pressing upArrow to jump at the same column position in the source code's line is useless because the cursor does not land in the same column.

Description of user facing changes

Use a fixed width font in the log viewer and in the Python console.
In the Python console, only the output field is impacted by vertical alignment considerations; however, for visual consistency I have modified both the input and the output fields.

Description of development approach

Change the log viewer's font to 'Consolas' which has fixed width and which is the one used in Notepad.

Testing strategy:

Manual tests:

  • Tested visually that the log viewer and the python console is using a fixed width.
  • Tested that vertical navigation is OK from error markers in a traceback
  • [ ]: Test required from a sighted person. (cc @Qchristensen or @gerald-hartig ?) to check the general appearance of the log viewer and python console for which I am not relevant.

Known issues with pull request:

None.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@CyrilleB79

Copy link
Copy Markdown
Contributor Author

The build can be downloaded here.

I would like to have a visual feedback of this new appearance of the log viewer before passing this PR to ready.
@Qchristensen, @gerald-hartig or anyone else sighted, would you mind provide a visual confirmation? Thanks.

@CyrilleB79 CyrilleB79 changed the title Use fixed width font in the log viewer Use fixed width font in the log viewer and the Python console Mar 28, 2024
@CyrilleB79

Copy link
Copy Markdown
Contributor Author

@Qchristensen or @gerald-hartig, could you please provide a visual feedback running this build, looking at the log viewer and the Python console?

Or I may provide screenshots if you want, hoping that the resolution of the picture will be OK. Let me know.

@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Apr 16, 2024
@CyrilleB79 CyrilleB79 marked this pull request as ready for review May 2, 2024 14:24
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner May 2, 2024 14:24
@CyrilleB79

Copy link
Copy Markdown
Contributor Author

This PR is ready on my side. Adding Quentin or Gerald as reviewers to have a visual feedback.

Comment thread user_docs/en/changes.t2t Outdated
@seanbudd

seanbudd commented May 6, 2024

Copy link
Copy Markdown
Member

The new font looks good to me, happy to hear what @gerald-hartig and @Qchristensen think as well

@seanbudd

seanbudd commented May 6, 2024

Copy link
Copy Markdown
Member

Co-authored-by: Sean Budd <seanbudd123@gmail.com>
@gerald-hartig

Copy link
Copy Markdown
Contributor

Looks good to me. Thanks for the link to the snapshot build @seanbudd

@seanbudd seanbudd added this to the 2024.3 milestone May 7, 2024
Comment thread user_docs/en/changes.md Outdated
@seanbudd seanbudd merged commit a0a2868 into nvaccess:master May 7, 2024
@CyrilleB79 CyrilleB79 deleted the logFont branch May 7, 2024 07:40
@AppVeyorBot

Copy link
Copy Markdown
  • Build execution time has reached the maximum allowed time for your plan (60 minutes).

See test results for failed build of commit df3c55c751

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. queued for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants