Add Documentation of the AppVeyor build process for NVDA forks#16293
Merged
Conversation
lukaszgo1
reviewed
Mar 12, 2024
See test results for failed build of commit 845802bcb7 |
Collaborator
Author
|
CC @Qchristensen |
seanbudd
reviewed
Mar 15, 2024
seanbudd
left a comment
Member
There was a problem hiding this comment.
generally looks good. I would suggest changing Appveyor to AppVeyor across this diff
| *(FixMe: more instructions may be needed here.)* | ||
| 4. Move to the "Select repository for your new project" heading, and then to the heading representing your GitHub username. | ||
| 5. Below that heading, you should find your GitHub repositories listed. Go to the one representing your NVDA fork. | ||
| 6. This part is less than perfectly accessible via the usual methods: you will need to use NVDA+numpad divide, to route the mouse to the repository name, and then numpad divide to click on it. |
Member
There was a problem hiding this comment.
Suggested change
| 6. This part is less than perfectly accessible via the usual methods: you will need to use NVDA+numpad divide, to route the mouse to the repository name, and then numpad divide to click on it. | |
| 6. This part is less than perfectly accessible via the usual methods: you will need to use `NVDA+numpad` divide, to route the mouse to the repository name, and then `numpadDivide` to click on it. |
Collaborator
Author
There was a problem hiding this comment.
"Divide" falls outside of the backticks in your suggestion. I have modified the spacing and casing to reach your intended outcome.
Suggested change
| 6. This part is less than perfectly accessible via the usual methods: you will need to use NVDA+numpad divide, to route the mouse to the repository name, and then numpad divide to click on it. | |
| 6. This part is less than perfectly accessible via the usual methods: you will need to use `NVDA+NumpadDivide`, to route the mouse to the repository name, and then `NumpadDivide` to click on it. |
Member
There was a problem hiding this comment.
Key commands should be written in lowerCamelCase
https://github.com/nvaccess/nvda/blob/master/projectDocs/dev/userGuideStandards.md#general-standards
The casing should be numpadDivide
added 2 commits
March 14, 2024 23:59
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
Just for future reference, it would have been better to keep the original commit. Commit messages don't matter much, and as it was a force push the PR has to be re-reviewed from scratch, rather than from the previous review |
Collaborator
Author
|
Just for future reference, it would have been better to keep the original commit. Commit messages don't matter much, and as it was a force push the PR has
to be re-reviewed from scratch, rather than from the previous review
Sorry.
|
Collaborator
Author
|
@seanbudd Fixed your last comment. Nothing left that I know of.
|
5 tasks
michaelDCurran
approved these changes
Apr 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Follow-up of #16221
Summary of the issue:
The streamlined AppVeyor build process implemented in #16221, requires documentation in order to be useful.
Description of user facing changes
None.
Description of development approach
projectDocs/dev/buildingNVDAOnAppVeyor.md.readme.mdandcontributing.md, at @seanbudd's suggestion.buildingNVDA.md.Testing strategy:
Checked all links to be working as of now.
Tested all commands.
I've been using variations of this process for three years.
Known issues with pull request:
None.
Code Review Checklist: