The solution provided by #15921 is not satisfactory at all. It does not solves all issues with unexpected restart dialog and creates more confusion about add-ons expected to be installed but actually not.
Steps to reproduce:
- Install 10dita application module and restart NVDA as needed
- Open the appModule sub-sub-folder of this add-on in Windows Explorer and keep this folder open
- Uninstall 10dita and restart NVDA as required
A1: The add-on's folder is still there and NVDA has not warned the user that the add-on could not be uninstalled.
E1: If nothing is said, the add-on is expected to be uninstalled successfully, else something should be said to the user.
- Install 10dita and restart
- Open Add-on store:
A2: The add-on is pending remove
E2: The add-on is installed
- Close the add-on store
A3: A dialog indicates that changes were made and that a restart is required.
E3: No such dialog since no change were made.
- Close Windows Explorer with the appModule folder open
- Press Yes in the restart dialog
A4: After restart, 10dita is not installed
E4: After restart, 10dita should be installed since the add-on installation was the last action of the user and the user has not been warned that an action has failed.
There are probably more scenarios causing issues, such as updating an add-on keeping a folder of the old add-on open in Windows Explorer.
Actual behavior:
See A1, A2, A3 and A4 in STR
Expected behavior:
See E1, E2, E3 and E4 in STR.
More generally, I think that the add-on store should not consider add-ons uninstalled if they have not been installed successfully. The real state (pending remove here) of the add-on should be displayed.
On the other side with #15719, if installation fails, NVDA should not start normally and remove silently the add-on. Unless I am mistaken, the root cause of #1571 has not been addressed in #15921 (nor found), so failing silently will not help to find this root cause.
Maybe the solution of @lukaszgo1 in #15921 (comment) can be of interest.
NVDA logs, crash dumps and other attachments:
None
System configuration
NVDA installed/portable/running from source:
From source
NVDA version:
Last beta branch, commit 81e17be.
Windows version:
Windows 10 22H2 (AMD64) build 19045.3693
Name and version of other software in use when reproducing the issue:
N/A
Other information about your system:
N/A
Other questions
Does the issue still occur after restarting your computer?
Not tested.
Have you tried any other versions of NVDA? If so, please report their behaviors.
N/A, (#15921 just merged.
If NVDA add-ons are disabled, is your problem still occurring?
N/A
Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?
Not tested
The solution provided by #15921 is not satisfactory at all. It does not solves all issues with unexpected restart dialog and creates more confusion about add-ons expected to be installed but actually not.
Steps to reproduce:
A1: The add-on's folder is still there and NVDA has not warned the user that the add-on could not be uninstalled.
E1: If nothing is said, the add-on is expected to be uninstalled successfully, else something should be said to the user.
A2: The add-on is pending remove
E2: The add-on is installed
A3: A dialog indicates that changes were made and that a restart is required.
E3: No such dialog since no change were made.
A4: After restart, 10dita is not installed
E4: After restart, 10dita should be installed since the add-on installation was the last action of the user and the user has not been warned that an action has failed.
There are probably more scenarios causing issues, such as updating an add-on keeping a folder of the old add-on open in Windows Explorer.
Actual behavior:
See A1, A2, A3 and A4 in STR
Expected behavior:
See E1, E2, E3 and E4 in STR.
More generally, I think that the add-on store should not consider add-ons uninstalled if they have not been installed successfully. The real state (pending remove here) of the add-on should be displayed.
On the other side with #15719, if installation fails, NVDA should not start normally and remove silently the add-on. Unless I am mistaken, the root cause of #1571 has not been addressed in #15921 (nor found), so failing silently will not help to find this root cause.
Maybe the solution of @lukaszgo1 in #15921 (comment) can be of interest.
NVDA logs, crash dumps and other attachments:
None
System configuration
NVDA installed/portable/running from source:
From source
NVDA version:
Last beta branch, commit 81e17be.
Windows version:
Windows 10 22H2 (AMD64) build 19045.3693
Name and version of other software in use when reproducing the issue:
N/A
Other information about your system:
N/A
Other questions
Does the issue still occur after restarting your computer?
Not tested.
Have you tried any other versions of NVDA? If so, please report their behaviors.
N/A, (#15921 just merged.
If NVDA add-ons are disabled, is your problem still occurring?
N/A
Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?
Not tested