Add-on store: emit a namechange event when a list item is updated#15859
Merged
Conversation
seanbudd
approved these changes
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
When installing an add-on, the state of the add-on is updated in the list, but state changes aren't pronounced by NVDA.
Description of user facing changes
Re-announce the list item after an item update.
Description of development approach
Send a namechange event to the selected list item
Testing strategy:
Tested installing an add-on, ensured that the status update from
downloadingtodownloaded, pending installand that this was announced correctly.Known issues with pull request:
The whole list item is announced instead of only the changed column. Note that the announcement is triggered by a MSAA name change event. Of course it is technically possible to announce changed columns only, but that would require much more custom code.
Code Review Checklist: