Skip to content

Add-on store: emit a namechange event when a list item is updated#15859

Merged
seanbudd merged 3 commits into
nvaccess:masterfrom
LeonarddeR:refreshState
Nov 30, 2023
Merged

Add-on store: emit a namechange event when a list item is updated#15859
seanbudd merged 3 commits into
nvaccess:masterfrom
LeonarddeR:refreshState

Conversation

@LeonarddeR

Copy link
Copy Markdown
Collaborator

Link to issue number:

None

Summary of the issue:

When installing an add-on, the state of the add-on is updated in the list, but state changes aren't pronounced by NVDA.

Description of user facing changes

Re-announce the list item after an item update.

Description of development approach

Send a namechange event to the selected list item

Testing strategy:

Tested installing an add-on, ensured that the status update from downloading to downloaded, pending install and that this was announced correctly.

Known issues with pull request:

The whole list item is announced instead of only the changed column. Note that the announcement is triggered by a MSAA name change event. Of course it is technically possible to announce changed columns only, but that would require much more custom code.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@LeonarddeR LeonarddeR requested a review from a team as a code owner November 29, 2023 19:10
@LeonarddeR LeonarddeR added the feature/addon-store Features / behavior of the add-on Store label Nov 29, 2023
@seanbudd seanbudd merged commit cf64fa9 into nvaccess:master Nov 30, 2023
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Nov 30, 2023
@LeonarddeR LeonarddeR deleted the refreshState branch August 23, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature/addon-store Features / behavior of the add-on Store

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants