Remove architecture suffix from nvdaControllerClient.dll#15718
Merged
Conversation
See test results for failed build of commit 2b0cf614bf |
seanbudd
reviewed
Oct 31, 2023
| @@ -1,20 +1,20 @@ | |||
| import time | |||
| import ctypes | |||
| import time | |||
Member
There was a problem hiding this comment.
can this get copyright headers added?
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #15717
Summary of the issue:
The controller client library for ARM64 is called nvdaControllerClient32.dll
Description of user facing changes
None, devs only change
Description of development approach
Remove the 32/64 suffix from nvdaControllerClient32/64.dll. This change also has the benefit that python/c# samples run without change for X64 versions of the dll.
Testing strategy:
Only file name changes.
Known issues with pull request:
None known
Code Review Checklist: