Skip to content

Disable speech and braille viewer in secure mode#15680

Merged
seanbudd merged 4 commits into
masterfrom
blockViewersSecure
Oct 26, 2023
Merged

Disable speech and braille viewer in secure mode#15680
seanbudd merged 4 commits into
masterfrom
blockViewersSecure

Conversation

@seanbudd

Copy link
Copy Markdown
Member

Link to issue number:

None

Summary of the issue:

Speech and braille viewer are not required and may cause secure information to be retained in testing environments, where secure mode is often used.

Description of user facing changes

Disable speech and braille viewer in secure mode

Description of development approach

Disable speech and braille viewer in secure mode

Testing strategy:

Test trying to open speech and braille viewer when starting NVDA with --secure

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@seanbudd seanbudd requested review from a team as code owners October 25, 2023 05:28
@seanbudd seanbudd merged commit 7f7ae4a into master Oct 26, 2023
@seanbudd seanbudd deleted the blockViewersSecure branch October 26, 2023 22:45
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants