Include python3.dll in the binary distribution for use in add-ons.#15674
Merged
Conversation
Contributor
Author
|
CC @josephsl |
See test results for failed build of commit 293fe295b7 |
See test results for failed build of commit 5da4851253 |
LeonarddeR
approved these changes
Oct 25, 2023
See test results for failed build of commit a5ed8df7dd |
seanbudd
reviewed
Oct 26, 2023
seanbudd
reviewed
Oct 26, 2023
seanbudd
approved these changes
Oct 26, 2023
Collaborator
|
@seanbudd For the stable ABI link, why not use the full direct URL?
https://docs.python.org/3.11/c-api/stable.html#stable-abi
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
fixes #15594
Summary of the issue:
NVDA add-ons that rely on .pyd files, like Resource Monitor, encounter compatibility issues due to the absence of python3.dll in NVDA's distribution. The issue becomes more complicated with NVDA's upgrade to Python 3.11, as it necessitates manually bundling multiple versions of python3.dll to maintain backward compatibility.
Description of user facing changes
None.
Description of development approach
In the setup.py file, bundle python3.dll from sys.base_prefix, which should be the python version used to build NVDA.
Testing strategy:
Override compatibility for Resource Monitor 23.10. It should function normally instead of a DLL error occurring.
Known issues with pull request:
None.
Code Review Checklist: