Update SCons to version 4.5.2#15529
Merged
Merged
Conversation
Member
|
Please wait until the py 3.11 upgrade is prepared |
seanbudd
approved these changes
Sep 27, 2023
seanbudd
left a comment
Member
There was a problem hiding this comment.
Disregard, but I would discourage making similar updates until next week, when a stable py3.11 base PR should be ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
As part of the investment to update all NVDA dependencies, SCons needs an update to the most recent version.
Description of user facing changes
Updates Scons to 4.5.2
Description of development approach
Updates requirements. As CPPDEFINES is now saved as a deque internally, I needed to convert the deque to a list before expanding it for one of the libraries.
Testing strategy:
Tested that NVDA builds and that a launcher can still be created.
Known issues with pull request:
None known
Code Review Checklist: