Skip to content

Update SCons to version 4.5.2#15529

Merged
seanbudd merged 2 commits into
nvaccess:masterfrom
LeonarddeR:scons4.5.2
Sep 27, 2023
Merged

Update SCons to version 4.5.2#15529
seanbudd merged 2 commits into
nvaccess:masterfrom
LeonarddeR:scons4.5.2

Conversation

@LeonarddeR

@LeonarddeR LeonarddeR commented Sep 26, 2023

Copy link
Copy Markdown
Collaborator

Link to issue number:

None

Summary of the issue:

As part of the investment to update all NVDA dependencies, SCons needs an update to the most recent version.

Description of user facing changes

Updates Scons to 4.5.2

Description of development approach

Updates requirements. As CPPDEFINES is now saved as a deque internally, I needed to convert the deque to a list before expanding it for one of the libraries.

Testing strategy:

Tested that NVDA builds and that a launcher can still be created.

Known issues with pull request:

None known

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@LeonarddeR LeonarddeR requested a review from a team as a code owner September 26, 2023 16:40
@LeonarddeR LeonarddeR requested a review from seanbudd September 26, 2023 16:40
@seanbudd

Copy link
Copy Markdown
Member

Please wait until the py 3.11 upgrade is prepared

@seanbudd seanbudd closed this Sep 26, 2023
@seanbudd seanbudd reopened this Sep 27, 2023

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disregard, but I would discourage making similar updates until next week, when a stable py3.11 base PR should be ready

@seanbudd seanbudd merged commit 72e4ff9 into nvaccess:master Sep 27, 2023
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Sep 27, 2023
@LeonarddeR LeonarddeR deleted the scons4.5.2 branch August 23, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants