Skip to content

Support bluetooth low energy HID Braille displays#15470

Merged
seanbudd merged 4 commits into
nvaccess:masterfrom
tactile-eng:ble-hid-support
Sep 20, 2023
Merged

Support bluetooth low energy HID Braille displays#15470
seanbudd merged 4 commits into
nvaccess:masterfrom
tactile-eng:ble-hid-support

Conversation

@alexmoon

@alexmoon alexmoon commented Sep 19, 2023

Copy link
Copy Markdown
Contributor

Summary of the issue:

NVDA does not currently detect standard HID braille displays using the Bluetooth Low Energy transport. This PR adds the BLE GATT HIDS UUID to be detected as a valid Bluetooth HID device.

Description of user facing changes

BLE HID braille displays will now be detected. No other user facing changes.

Testing strategy:

Checked that NVDA detects and uses our BLE braille display. Unit/system tests are not applicable due to required hardware interactions.

Known issues with pull request:

None

Change log entries:

Bug fixes

  • Support Bluetooth Low Energy HID Braille displays

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@codeofdusk

codeofdusk commented Sep 19, 2023

Copy link
Copy Markdown
Contributor

Are there any actively used HID displays that communicate over BLE?

@alexmoon

alexmoon commented Sep 19, 2023

Copy link
Copy Markdown
Contributor Author

Are there any actively used HID displays that communicate over BLE?

Yes, Tactile Engineering's Cadence tablet is now making its way onto the market and it uses BLE.

@josephsl

josephsl commented Sep 19, 2023 via email

Copy link
Copy Markdown
Contributor

@LeonarddeR

LeonarddeR commented Sep 20, 2023

Copy link
Copy Markdown
Collaborator

I recall @bramd has performed some tests with BLE in the past. Would like to know whether he has anything to add.

@josephsl wrote:

Hi, I see. I would like to suggest that, in the future, when discussing new technology support, let us go through issue+PR pair so we can discuss this in detail on the issue side before coming up with a pull request please. That way we can talk about rationale, supporting documentation (if any(, and have time to discuss specifics and strategies. Thanks.

While this is generally true, I think with a two lines change like this, it makes sense to have the suggestion as part of the pr.

@seanbudd

seanbudd commented Sep 20, 2023

Copy link
Copy Markdown
Member

Is this ready for review?

seanbudd
seanbudd reviewed Sep 20, 2023
View reviewed changes
Comment thread source/hwPortUtils.py
@alexmoon @seanbudd
Update source/hwPortUtils.py
e100be4 
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
@alexmoon alexmoon marked this pull request as ready for review September 20, 2023 12:12
@alexmoon alexmoon requested a review from a team as a code owner September 20, 2023 12:12
@alexmoon alexmoon requested a review from seanbudd September 20, 2023 12:12
seanbudd
seanbudd approved these changes Sep 20, 2023
View reviewed changes

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexmoon

@seanbudd

seanbudd commented Sep 20, 2023

Copy link
Copy Markdown
Member

Hi @alexmoon,

We are unable to push changes to your branch.
If possible, please give NV Access or myself push permissions?
Related docs.

Alternatively, could you please integrate the change log entry into changes.t2t under feature requests?

- Added support for Bluetooth Low Energy HID Braille displays. (#15470)
-

@seanbudd seanbudd merged commit fcb5808 into nvaccess:master Sep 20, 2023
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Sep 20, 2023
@alexmoon

alexmoon commented Sep 20, 2023

Copy link
Copy Markdown
Contributor Author

Thanks @seanbudd!

@seanbudd seanbudd mentioned this pull request Oct 11, 2023
Merged
5 tasks
@beqabeqa473 beqabeqa473 mentioned this pull request Nov 9, 2023
Closed
5 tasks
@CyrilleB79 CyrilleB79 mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanbudd seanbudd seanbudd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2024.1

Development

Successfully merging this pull request may close these issues.

6 participants

@alexmoon @codeofdusk @josephsl @LeonarddeR @seanbudd @nvaccessAuto