Steps to reproduce:

1. Configure NVDA not to save settings on exit, and save config
2. Create a test profile and activate it manually
3. Launch the Add-on Store
4. When the Warning dialog is shown, check "Don't show again" checkbox and validate
5. Exit the Store
   5.1 Disable the test profile (thus turn back to default profile)
6. Launch the Store
7. When the Warning dialog is shown, check "Don't show again" checkbox and validate
8. Exit the store and restart NVDA
9. Work on something else and modify various NVDA settings, e.g. doc formatting settings. These modifications are not meant to be saved since NVDA config is not automatically saved.
10. Launch the Store
11. When the Warning dialog is shown, check "Don't show again" checkbox and validate
12. Save your config to avoid being bothered again with the Warning dialog

Actual behavior:

Step 6: the warning dialog is shown again.
Step 10: the warning dialog is shown again.
Step 12: To be able to save the "Don't show again" status, the user also needs to save doc formatting settings are saved

Expected behavior:

Step 6: The warning should not be shown because the "Don't show again" checkbox is not expected to be profile dependent.
Step 10: The warning should not be shown because the "Don't show again" checkbox should have been taken into account whether the user chooses to save the config or not .
Step 12: The user has had to save doc formatting settings whereas they didn't want to.

To summarize, memorizing the "Don't show again" choice:

• should not be profile dependent
• should be always saved independently of other NVDA settings

Notes

@michaelDCurran has objected in #15246 (comment) that other dialog's status is saved the same way in the config. However, the case of the Add-on Store's warning causes more issues because:

• Welcome and stat dialogs are usually shown when NVDA is first started; thus, there are not yet profile enabled and the auto save is enabled by default
• Not checked, but I think that the setting for these dialogs are saved in a config section that exists only in default profile
• In NVDA, there are probably other issues of settings that can be saved in profile whereas the use case is probably not applicable to profiles

NVDA logs, crash dumps and other attachments:

N/A

System configuration

NVDA installed/portable/running from source:

installed

NVDA version:

2023.2beta1

Windows version:

Windows 10 2004 (AMD64) build 19041.388

Name and version of other software in use when reproducing the issue:

N/A

Other information about your system:

N/A

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

N/A

If NVDA add-ons are disabled, is your problem still occurring?

N/A

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

N/A