Albatross: gesture for move system caret when routing review cursor#15122
Merged
seanbudd merged 3 commits intoJul 12, 2023
Merged
Conversation
seanbudd
approved these changes
Jul 11, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
Qchristensen
requested changes
Jul 12, 2023
Qchristensen
left a comment
Member
There was a problem hiding this comment.
I think the User Guide change:
Cycle the braille move system caret when routing review cursor states
should have quotes around the option:
Cycle the "braille move system caret when routing review cursor" states
(This would mean the other pre-existing option lines should be updated, but this one particularly looked out of place as one statement otherwise).
Collaborator
|
Shouldn't it be "braille moves system caret when routing review cursor"
|
See test results for failed build of commit 467cda2640 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
none
Summary of the issue:
Gesture for move system caret when routing review cursor
Description of user facing changes
| Cycle the braille move system caret when routing review cursor states |
f1+f3,f9+f11|Description of development approach
Testing strategy:
Tested with 80 model.
Known issues with pull request:
none
Change log entries:
New features
Changes
Gesture for move system caret when routing review cursor
Bug fixes
For Developers
Code Review Checklist: