Skip to content

Handy tech driver updates#14917

Merged
seanbudd merged 9 commits into
nvaccess:masterfrom
FelixGruetzmacher:handy_tech_driver_updates
Jun 1, 2023
Merged

Handy tech driver updates#14917
seanbudd merged 9 commits into
nvaccess:masterfrom
FelixGruetzmacher:handy_tech_driver_updates

Conversation

@FelixGruetzmacher

@FelixGruetzmacher FelixGruetzmacher commented May 10, 2023

Copy link
Copy Markdown
Contributor

Summary of the issue:

Help Tech Activator Braille display was not supported.

Description of user facing changes

Activator is now detected and can be used.

Description of development approach

Modified driver and detection logic.

Testing strategy:

Tested Braille with updated driver in developer scratchpad.

Change log entries:

Help Tech Activator now supported.

@FelixGruetzmacher FelixGruetzmacher requested a review from a team as a code owner May 10, 2023 12:33
@codeofdusk

codeofdusk commented May 11, 2023

Copy link
Copy Markdown
Contributor

@FelixGruetzmacher A couple of asides if I may:

  • The PR title refers to "Handy Tech", but the changelog and website are "Help Tech". Was the company renamed or merged? What's the relationship between Handy Tech and Help Tech?
  • I'm extremely interested in the Activator whenever it comes out! Do you have any idea of a release date yet? (feel free to email me about this at my username at gmail dot com as not to clutter the PR comments).

codeofdusk
codeofdusk reviewed May 11, 2023
View reviewed changes
Comment thread source/brailleDisplayDrivers/handyTech.py
seanbudd
seanbudd reviewed Jun 1, 2023
View reviewed changes
Comment thread source/brailleDisplayDrivers/handyTech.py Outdated
seanbudd
seanbudd reviewed Jun 1, 2023
View reviewed changes
Comment thread source/brailleDisplayDrivers/handyTech.py Outdated
FelixGruetzmacher and others added 2 commits June 1, 2023 14:38
@FelixGruetzmacher @seanbudd
Update source/brailleDisplayDrivers/handyTech.py to use super() witho…
0f9076d 
…ut arguments as it is now the recommended idiom in Python.

Co-authored-by: Sean Budd <seanbudd123@gmail.com>
@FelixGruetzmacher @seanbudd
Update source/brailleDisplayDrivers/handyTech.py to add a missing typ…
4c81f28 
…e hint.

Co-authored-by: Sean Budd <seanbudd123@gmail.com>
@AppVeyorBot

AppVeyorBot commented Jun 1, 2023

Copy link
Copy Markdown

See test results for failed build of commit b54f0095d2

seanbudd
seanbudd approved these changes Jun 1, 2023
View reviewed changes

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FelixGruetzmacher

@seanbudd seanbudd merged commit 5ebe0a6 into nvaccess:master Jun 1, 2023
@nvaccessAuto nvaccessAuto added this to the 2023.2 milestone Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanbudd seanbudd seanbudd approved these changes

+1 more reviewer

@codeofdusk codeofdusk codeofdusk left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2023.2

Development

Successfully merging this pull request may close these issues.

5 participants

@FelixGruetzmacher @codeofdusk @AppVeyorBot @seanbudd @nvaccessAuto