Inform the user that the configuration cannot be saved from a temporary version of NVDA (launcher)#14914
Merged
Merged
Conversation
…ry version of NVDA (launcher)
josephsl
pushed a commit
to josephsl/nvda
that referenced
this pull request
May 31, 2023
…ry version of NVDA (launcher) (nvaccess#14914) Summary of the issue: When running NVDA temp version (from launcher), the configuration cannot be save due to possible compatibility of version scheme. When pressing NVDA+control+C, the configuration is not saved and a message is logged in the log. However, NVDA reports "Configuration saved". Description of user facing changes When running the temporary version of the launcher: NVDA will not report erroneously that the config was saved when trying to save it with NVDA+control+C command. NVDA will also not offer anymore the possibility to save the configuration in the NVDA menu. Description of development approach As when running in secure mode: When trying to save the config, use the decorator to block action and report that the config cannot be saved in this version of NVDA. Also removed the "Save configuration" item in the NVDA menu when running the temp version (launcher)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
When running NVDA temp version (from launcher), the configuration cannot be save due to possible compatibility of version scheme. When pressing NVDA+control+C, the configuration is not saved and a message is logged in the log. However, NVDA reports "Configuration saved".
Description of user facing changes
When running the temporary version of the launcher:
Description of development approach
As when running in secure mode:
Testing strategy:
Manual tests:
Launched NVDA with and without the
--launcherparameter and checked NVDA+control+C and the NVDA menu.Known issues with pull request:
None
Change log entries:
Bug fixes
When running a temporary version from the launcher, NVDA will not let the users think that they can save the configuration. (#14914)Code Review Checklist: