Add support of getting link destination of graphic links#14783
Merged
seanbudd merged 3 commits intoApr 5, 2023
Conversation
Collaborator
|
Are image links also covered? See |
Contributor
Author
|
That was a purpose of creating this pr |
Collaborator
|
Ah ok sorry I thought there might be a difference between grafic links and image links, didn't mean to spam this. :-) |
seanbudd
reviewed
Apr 4, 2023
Member
|
Thanks @beqabeqa473 - just a minor fix required in regards to comments |
See test results for failed build of commit fbca680220 |
1b109cf to
58079fb
Compare
seanbudd
approved these changes
Apr 5, 2023
|
@beqabeqa473 @seanbudd I have Alpha 28043 for this graphic link-oriented fix, but it introduces one more serious issue.
|
Contributor
Author
|
It is not related for this pr and linked issue. |
|
You are right. I tested it with previous alphas and issue is duplicable. It
seems that NVDA can’t get or report the destination of links which are
embedded in headings - a serious issue IMO.
On Thu, Apr 6, 2023 at 08:07 Beqa Gozalishvili ***@***.***> wrote:
It is not related for this pr and linked issue.
I still have earlier alpha on my machine and can reproduce bug you are
talking
—
Reply to this email directly, view it on GitHub
<#14783 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIGLZMXZ3G35RK5FGCNH2YDW7ZCBPANCNFSM6AAAAAAWSHWFCA>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
Sent from Gmail Mobile via iPhone
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #14779
Summary of the issue:
destination of graphic links are not reported in chrome/edge
Description of user facing changes
Destination of graphic links now should be reported in chrome/edge browsers
Description of development approach
NVDA lands its focus to graphic elemeng "img" which does not have href value, but an element which is parent of that element is link.
So one more check was introduced to ensure han if we are focusing a graphic element and its parent is a link, we are now replacing an object by its parent object
Testing strategy:
Opened a webpage with graphic links and ensured that their addresses are correctly reported
Known issues with pull request:
None
Change log entries:
New features
Changes
Bug fixes
Destination of graphic links are now corectly reported in chrome and edge browsers
For Developers
Code Review Checklist: