Baum braille driver: provide more mappings for common keyboard commands#14714
Merged
Conversation
…eyboard gestures: - shift+tab key | space+dot1+dot3 - tab key | space+dot4+dot6 - alt key | space+dot1+dot3+dot4 (space+m) - escape key | space+dot1+dot5 (space+e) - windows key | space+dot3+dot4 - alt+tab key | space+dot2+dot3+dot4+dot5 (space+t) - NVDA Menu | space+dot1+dot3+dot4+dot5 (space+n) - windows+d key (minimize all applications) | space+dot1+dot4+dot5 (space+d) - Say all | space+dot1+dot2+dot3+dot4+dot5+dot6
seanbudd
reviewed
Mar 23, 2023
| | alt key | space+dot1+dot3+dot4 (space+m) | | ||
| | escape key | space+dot1+dot5 (space+e) | | ||
| | windows key | space+dot3+dot4 | | ||
| | alt+tab key | space+dot2+dot3+dot4+dot5 (space+t) | |
Member
There was a problem hiding this comment.
Could the keys be wrapped in monospace formatting?
Suggested change
| | alt+tab key | space+dot2+dot3+dot4+dot5 (space+t) | | |
| | ``alt+tab`` key | ``space+dot2+dot3+dot4+dot5`` (``space+t``) | |
Member
Author
There was a problem hiding this comment.
It seems to me that many of these gesture tables don't markup the keys like that yet. I'm unclear as to whether it should be done for script names as well? E.g. "scroll forward"?
Perhaps this could be done as a separate pr that goes through the user guide as a whole, as it will make the diff harder to read if I go through and doo the entire table here...
Member
There was a problem hiding this comment.
The userGuide standards only suggest doing this for key commands https://github.com/nvaccess/nvda/blob/master/devDocs/userGuideStandards.md
seanbudd
approved these changes
Mar 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
The Baum braille driver does not provide mappings for several common keyboard commands like other Braille drivers do. Examples being windows+d, tab, shift+tab etc.
Description of changes
As requested by Orbit for the Baum braille driver, Add several Braille gestures mapped to common keyboard commands
Testing strategy:
Enabled NVDA input help with NVDA+1
Pressed each of the braille gestures listed above, and ensured the correct keyboard gesture was emulated.
Known issues with pull request:
None known.
Change log entries:
New features
Changes
Bug fixes
For Developers
Code Review Checklist: