Respect non-config settings on synth drivers#14601
Merged
Merged
Conversation
michaelDCurran
approved these changes
Feb 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
A synth driver inherrits from
autoSettingsUtils.autoSettings.AutoSettingsbut overrides its loadSettings method to work around changing the voice. However, that override doesn't respect settings that aren't saved in config, like the parent class does.Description of user facing changes
None
Description of development approach
Ensure that a synth doesn't try to get a setting from config that's not a setting stored in config.
Testing strategy:
Tested with an add-on that had synth settings with useConfig set to False. The synth was able to load again.
Known issues with pull request:
None
Change log entries:
For Developers
useConfigto False on supported settings for a synthesizer driver.Code Review Checklist: