Allow exporting a gesture map without saving it#14582
Merged
Merged
Conversation
See test results for failed build of commit 0333708cd2 |
See test results for failed build of commit 1880042726 |
See test results for failed build of commit c693e7ffa9 |
seanbudd
reviewed
Mar 23, 2023
seanbudd
approved these changes
Mar 23, 2023
seanbudd
left a comment
Member
There was a problem hiding this comment.
@LeonarddeR looks good to me generally, can you add this missing typing?
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
Collaborator
Author
|
Done, thanks for approving! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
You can currently load a gesture map from a file or a dictionary, but you can only save it as a file, i.e. you can't go from gesture map to the flattened dictionary format.
Description of user facing changes
None
Description of development approach
SPlit out the save function into another function called export. The save function uses the export function internally. This can also be used for unit testing the code as demonstrated. Furthermore, it is useful for braille display driver authors to develop a gesture map in the user gesture map, then export it from the python console to include it in their driver in the proper format.
Testing strategy:
Tested manually that exporting the gesture map and then importing it again results in the same map.
Known issues with pull request:
None
Change log entries:
For Developers
Code Review Checklist: