Skip to content

Rename postSessionLockStateChanged to post_sessionLockStateChanged#14486

Merged
seanbudd merged 2 commits into
masterfrom
fixUpExtensionPointNamingConvention
Jan 4, 2023
Merged

Rename postSessionLockStateChanged to post_sessionLockStateChanged#14486
seanbudd merged 2 commits into
masterfrom
fixUpExtensionPointNamingConvention

Conversation

@seanbudd

@seanbudd seanbudd commented Dec 29, 2022

Copy link
Copy Markdown
Member

Link to issue number:

None

Summary of the issue:

postSessionLockStateChanged was named incorrectly, the convention would be to name it post_sessionLockStateChanged.

Description of user facing changes

None

Description of development approach

Deprecates postSessionLockStateChanged in favour of post_sessionLockStateChanged.

  • After merging, announce on the addon-api list

Testing strategy:

Tested importing utils.security.postSessionLockStateChanged from python console

Known issues with pull request:

None

Change log entries:

Refer to diff

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner December 29, 2022 02:33
@seanbudd seanbudd requested review from feerrenrut and michaelDCurran and removed request for feerrenrut December 29, 2022 02:33
@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit ab079bd93b

@seanbudd seanbudd added this to the 2023.1 milestone Dec 30, 2022
@seanbudd seanbudd merged commit a8a2c72 into master Jan 4, 2023
@seanbudd seanbudd deleted the fixUpExtensionPointNamingConvention branch January 4, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants